Skip to content

Improve #6041, Migrate to CircleCI 2.0 #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 18, 2017
Merged

Conversation

serima
Copy link
Contributor

@serima serima commented Sep 17, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

We are going to migrate to CircleCI 2.0 with #6041, but with a simpler description, we can make the build run time shorter.

When caching node_modules, the build is now finished in 1 minute 20 seconds.
https://circleci.com/workflow-run/7ea0d4e0-48ca-449d-9a52-9880dbbd93a5

In the case of 2.0, we have to describe all of the procedures procedurally, but on the contrary, I think that approach is easy to understand.

Please check this PR 😃 @yyx990803 @posva

@yyx990803
Copy link
Member

Very nice! I noticed that our CI actually has a 4x parallelism limit, so I merged some of the jobs together to minimize queueing.

@serima
Copy link
Contributor Author

serima commented Sep 18, 2017

@yyx990803 Thank you for balancing the test! It got faster!

@serima serima deleted the feature/circleci-20 branch September 18, 2017 20:40
ztlevi pushed a commit to ztlevi/vue that referenced this pull request Feb 14, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants