This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacesailor24
previously approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the two commented imports, lgtm!
a8090d4
to
109e0c5
Compare
b124b01
to
27a22e1
Compare
27a22e1
to
7fdf653
Compare
fe2989e
to
d652438
Compare
d652438
to
b0cb0ea
Compare
ryanio
reviewed
Jul 23, 2020
spacesailor24
previously approved these changes
Jul 23, 2020
@spacesailor24 and @ryanio I updated the changelog and addressed a previous comment. Ready for re-review. |
@GregTheGreek looks good 👍 in the past we have only merged changes to |
hmm let me look at that, i thought i pulled in the ones from |
ryanio
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on adding TypeScript in an incremental way. Currently
allowJs
is enabled allowing us to write TypeScript and JavaScript side by side. The configuration is very lenient, and in the future as we make progress on the typescript interfaces we should tighten it up.It also:
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.