This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replicating the steps mentioned in previous release for As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.
(This list will be actively edited)
UPDATE Previously For 168 passing (14s)
1 failing
1) Contract: expectEvent (web3 contracts)
"before each" hook for "accepts emitted events":
Error: Returned error: Exceeds block gas limit
at Object.ErrorResponse (node_modules/web3-core-helpers/src/errors.js:29:16)
at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-core-requestmanager/src/index.js:140:36
at /home/anon/tmp/openzeppelin-test-helpers/node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:112:1
at XMLHttpRequest.request.onreadystatechange (node_modules/truffle/build/webpack:/~/web3/~/web3-providers-http/src/index.js:96:1)
at XMLHttpRequestEventTarget.dispatchEvent (node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request-event-target.js:34:1)
at XMLHttpRequest._setReadyState (node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request.js:208:1)
at XMLHttpRequest._onHttpResponseEnd (node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request.js:318:1)
at IncomingMessage.<anonymous> (node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request.js:289:47)
at endReadableNT (_stream_readable.js:1187:12)
at processTicksAndRejections (internal/process/task_queues.js:84:21) |
I tested the new |
spacesailor24
previously approved these changes
Sep 9, 2020
frankiebee
previously approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Thank you!!
a88944f
spacesailor24
approved these changes
Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This minor release contains an assortment of improvements, and is the first release by @ChainSafeSystems
Changelog
Added
Changed
npm run build
now uses TSC to compile (.js allowed) and the build folder is now located underlib
(Add typescript support #3652)web3-providers-ipc
oboe
version to 2.1.5 (Bump web3-providers-ipc oboe version to 2.1.5 #3661)Fixed
eth_subscription
provider events (Fix parsing of non-eth_subscription
provider events #3660)clearSubscriptions
(clearSubscriptions return undefined #3689)Compare View
v1.2.11 -> v1.3.0
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.