This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Not implemented error with react native #3666
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregTheGreek
suggested changes
Aug 3, 2020
new URL(url) -> require('url').parse(url)
another example bug
close and pr again |
This reverts commit 69f5045.
Can you please update the changelog :) |
@daoauth Do you have an example repo I could check out to verify this? I'd love to eventually add react-native support as a part of the CI run... |
https://github.com/daoauth/web3js-react-native-ws |
GregTheGreek
previously approved these changes
Aug 9, 2020
GregTheGreek
previously approved these changes
Aug 31, 2020
spacesailor24
suggested changes
Aug 31, 2020
Co-authored-by: Wyatt Barnes <[email protected]>
Changes seem to follow documentation |
GregTheGreek
approved these changes
Sep 2, 2020
spacesailor24
approved these changes
Sep 2, 2020
@@ -1,8 +1,9 @@ | |||
var isNode = Object.prototype.toString.call(typeof process !== 'undefined' ? process : 0) === '[object process]'; | |||
var isRN = typeof navigator !== 'undefined' && navigator.product === 'ReactNative'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the correct way to check if running ReactNative
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from
to
Fixes #3667
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.