Skip to content

Warn about orphaned object types #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Conversation

quadrifolia
Copy link
Contributor

Better error when the object type is not available because it is only used as object type within an interface. The "multiple types" error on ($runtimeType !== $this->exeContext->schema->getType($runtimeType->name)) is misleading, because the type is not available in the schema at all.

Better error when the object type is not available because it is only used as object type within an interface. The "multiple types" error on ($runtimeType !== $this->exeContext->schema->getType($runtimeType->name)) is misleading, because the type is not available in the schema at all.
@mfn
Copy link
Contributor

mfn commented Jun 8, 2019

Shouldn't there be a test for this?

@quadrifolia
Copy link
Contributor Author

Probably yes. I just did a quick edit within the github website. It is just a new error message (no type detected) for this problem that took me some time because the existing error message (multiple types detected) led me into the wrong direction.

@vladar
Copy link
Member

vladar commented Jun 12, 2019

This is useful. But this PR breaks the build (in the coding style) + we need some tests for this

@simPod simPod force-pushed the master branch 2 times, most recently from 61b0907 to 8d37049 Compare December 14, 2019 12:33
@spawnia
Copy link
Collaborator

spawnia commented Aug 11, 2020

@quadrifolia are you still interested in pursuing this PR?

# Conflicts:
#	src/Executor/ReferenceExecutor.php
@spawnia spawnia changed the title Update ReferenceExecutor.php Warn about orphaned object types Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #491 (eebb225) into master (299be4f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #491   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files         117      117           
  Lines        9672     9679    +7     
=======================================
+ Hits         9119     9126    +7     
  Misses        553      553           
Impacted Files Coverage Δ
src/Executor/ReferenceExecutor.php 95.11% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac4c79...eebb225. Read the comment docs.

@spawnia spawnia merged commit ceeb8a3 into webonyx:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants