fix wrongly set correlation ids when sending a command #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2019 11:46
Fixing a bug where grabbit would set the message.CorrelationID and the message.SagaCorrelationID header even if the message was a command and not a reply.
vladshub
reviewed
Oct 22, 2019
| @@ -18,6 +18,8 @@ const ( | |||
| CMD Semantics = "cmd" | |||
| //EVT represenst a messge with event semantics in grabbit | |||
| EVT Semantics = "evt" | |||
| //REPLY represenst a messge with reply semantics in grabbit | |||
| REPLY Semantics = "reply" | |||
There was a problem hiding this comment.
Are we sure that this is the correct place to add this sematic? since we are not using it anywhere except for the internal implementation of setCorrelationId....
There was a problem hiding this comment.
I know, but it is worth making it explicit IMO
vladshub
approved these changes
Oct 22, 2019
rhinof
pushed a commit
that referenced
this pull request
Dec 2, 2019
* adding the SagaCorrelationID header only for replies Fixing a bug where grabbit would set the message.CorrelationID and the message.SagaCorrelationID header even if the message was a command and not a reply. * fixing minor documentation issue
vladshub
pushed a commit
that referenced
this pull request
Dec 2, 2019
* added reply to initiator functionality to sagas (#157) * added generic handler metrics with message type as the label (#144) * added generic handler metrics with message type as the label * add handler name label to the metrics * adding new metrics to the read me * Fix handle empty body (#156) * fixing ReplyToInitiator not working when initiator sends a message via the RPC interface (#163) * fixing ReplyToInitiator not working when initiator sends a message via the RPC interface * Improved wording of saga documentation article (#164) * better wording for documentation * added golangcli lint configuration and fixed linting failures (#165) * Fix logging and added logging documentation (#176) * fixed logging issues and added documentation logging via the invocation interface was broken and did not add contextual data related to the invocation due to a bug in the way the Glogged structure is currently implemented. Also added documentation on how logging should be done within a handler including adding context to returned errors so that data gets logged * added missing documentation file * added documentation on serialization support (#177) * fixed emperror url format * added serialization documentation * added documentation for messaging patterns, retries and transactional processing (#181) * fixed emperror url format * added serialization documentation * added documentation for message semantics, retries and transactions * Added sample application (#184) * fixing minor tech debt issues (#199) * fix(bug:200) logs are now being reported correctly Fixes issue #200 Also updated go.mod for newer versions of dependancies * fix wrongly set correlation ids when sending a command (#220) * adding the SagaCorrelationID header only for replies Fixing a bug where grabbit would set the message.CorrelationID and the message.SagaCorrelationID header even if the message was a command and not a reply. * fixing minor documentation issue * only sending headers over the wire if they contain a value (#222) * only sending headers over the wire if they contain a value fixing #221 * deleting file that was added by mistake * goodbye (#223) * goodbye * Fixing my last bug :) * Add saga latency metric (#224) records the execution time of the entire saga, from it's creation until deletion (in ms). having the "Service", "SagaType", "Initiator" as labels|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #219