Skip to content

goodbye #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2019
Merged

goodbye #223

merged 2 commits into from
Nov 18, 2019

Conversation

rhinof
Copy link
Contributor

@rhinof rhinof commented Nov 17, 2019

No description provided.

@rhinof rhinof requested review from vladshub, avigailberger, danielwitz and a user November 17, 2019 18:32
Copy link
Contributor

@vladshub vladshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will always be a member 😊 no need for such drama

Copy link
Contributor

@avigailberger avigailberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOLLLLLLLL

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 76.366% when pulling 7723fb7 on team into c4cb089 on v1.x.

@Prajna
Copy link

Prajna commented Nov 18, 2019

Good luck!

Copy link

@kleinron kleinron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't approve :)

Copy link
Contributor

@danielwitz danielwitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphub

@rhinof rhinof merged commit 4fdd9fc into v1.x Nov 18, 2019
@rhinof rhinof deleted the team branch November 18, 2019 16:22
rhinof pushed a commit that referenced this pull request Dec 2, 2019
* goodbye

* Fixing my last bug :)
vladshub pushed a commit that referenced this pull request Dec 2, 2019
* added reply to initiator functionality to sagas (#157)

* added generic handler metrics with message type as the label (#144)

* added generic handler metrics with message type as the label

* add handler name label to the metrics

* adding new metrics to the read me

* Fix handle empty body (#156)

* fixing ReplyToInitiator not working  when initiator sends a message via the RPC interface (#163)


* fixing ReplyToInitiator not working  when initiator sends a message via the RPC interface

* Improved wording of saga documentation article (#164)

* better wording for documentation

* added golangcli lint configuration and fixed linting failures (#165)

* Fix logging and added logging documentation (#176)

* fixed logging issues and added documentation

logging via the invocation interface was broken and did not add
contextual data related to the invocation due to a bug in the way the Glogged structure is currently implemented.

Also added documentation on how logging should be done within a
handler including adding context to returned errors so that data gets logged

* added missing documentation file

* added documentation on serialization support (#177)

* fixed emperror url format

* added serialization documentation

* added documentation for messaging patterns, retries and transactional processing (#181)

* fixed emperror url format

* added serialization documentation

* added documentation for message semantics, retries and transactions

* Added sample application (#184)

* fixing minor tech debt issues (#199)

* fix(bug:200) logs are now being reported correctly

Fixes issue #200
Also updated go.mod for newer versions of dependancies

* fix wrongly set correlation ids when sending a command (#220)

* adding the SagaCorrelationID header only for replies

Fixing a bug where grabbit would set the message.CorrelationID and the message.SagaCorrelationID header even
if the message was a command and not a reply.

* fixing minor documentation issue

* only sending headers over the wire if they contain a value (#222)

* only sending headers over the wire if they contain a value

fixing #221

* deleting file that was added by mistake

* goodbye (#223)

* goodbye

* Fixing my last bug :)

* Add saga latency metric (#224)

records the execution time of the entire saga, from it's creation until deletion (in ms). having the "Service", "SagaType", "Initiator" as labels|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants