-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
Let's see if this works!
The s3-image-uploader module doesn't do what we need it to as it can't handle file streams. The AWS SDK can handle them though, so this patch switches us to using that directly. Also removes all that fs code. /cc @brianlovin
… upgrade-image-uploads
Refactor image uploading
cypress.io is a tool that promises way more stable e2e tests. Ours have been very very flakey in CI, so I'm hoping this resolves it. It also comes with a super nice GUI, which is a big bonus. This moves all our existing e2e tests over to Cypress.
Make the PR and issue templates more clear to outside contributors when they come. Note that all of this required/auto-close stuff will be waived for us three and any future employees, and also isn't implemented yet.
Use Cypress for E2E tests
Update PR template and add issue template
Fixes Danger
Upgrade draft-js-plugin-no-console
Runs static checkers (ESlint, Flow) in parallel with web and native tests instead of sequentially
…token Join private channel with token
New dependencies added: aws-sdkAuthor: Amazon Web Services Description: AWS SDK for JavaScript Homepage: https://github.com/aws/aws-sdk-js
|
Created | over 6 years ago |
Last Updated | 4 days ago |
License | MIT |
Maintainers | 2 |
Releases | 23 |
Keywords | short, tiny, id, uuid, bitly, shorten, mongoid, shortid and tinyid |
Generated by 🚫 dangerJS
Run CircleCI jobs in parallel
Small fixes to help danger pass 2.1.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gotta merge the latest changes from alpha
into this then we'll be good to go
There we go @mxstbr - will need another review though :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM let's hope CI agrees!
Status
Deploy after merge (delete what needn't be deployed)