Skip to content

chore: remove unnecessary declare module block in typings #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

chore: remove unnecessary declare module block in typings #419

wants to merge 4 commits into from

Conversation

JounQin
Copy link

@JounQin JounQin commented Jul 19, 2022 •
edited
Loading

The typings are in its own package, so declare module is redundant.

@JounQin JounQin mentioned this pull request Jul 19, 2022
Closed
@JounQin
Copy link
Author

JounQin commented Jul 25, 2022

ping @wojtekmaj

@wojtekmaj
Copy link
Owner

In this case, what about entry.nostyle.d.ts?

@JounQin
Copy link
Author

JounQin commented Jul 25, 2022 •
edited
Loading

In this case, what about entry.nostyle.d.ts?

@wojtekmaj

It is not types in package.json, or the same dir as dist/entry.nostyle .js, so its declare module is required, and this PR will not break that.

Personally, I would prefer to have entry.nostyle.d.ts at dist/entry.nostyle.d.ts, then no declare module is required.

@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from c4d58cf to 6dc7a09 Compare September 6, 2022 09:42
@JounQin JounQin mentioned this pull request Sep 20, 2022
Closed
@wojtekmaj wojtekmaj force-pushed the main branch 8 times, most recently from ab5a30b to ff3a3ee Compare October 24, 2022 15:33
@wojtekmaj wojtekmaj force-pushed the main branch 10 times, most recently from 8182ad3 to 21af20c Compare November 7, 2022 12:58
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from e1c7dc5 to a524886 Compare January 4, 2023 23:23
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 98e1adb to e253cd3 Compare March 2, 2023 08:43
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 0b4cd33 to 9dfdb34 Compare April 5, 2023 11:00
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from c1a58a8 to 84b1863 Compare July 21, 2023 18:59
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 37e50fb to 5584926 Compare October 23, 2023 10:20
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 1fd7f2d to daa2c24 Compare November 2, 2023 07:30
@wojtekmaj
Copy link
Owner

No longer relevant as React-Date-Picker is now natively in TypeScript.

@wojtekmaj wojtekmaj closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JounQin @wojtekmaj @mpham-r7