[Android] TalkBack now reads name and helptext on buttons.

Xamarin.Forms.ControlGallery.Android/ContentDescriptionEffectRenderer.cs

@@ -0,0 +1,45 @@
+using System.ComponentModel;
+using AViews = Android.Views;
+using AWidget = Android.Widget;
+using Xamarin.Forms;
+using Xamarin.Forms.ControlGallery.Android;
+using Xamarin.Forms.Controls.Issues;
+using Xamarin.Forms.Platform.Android;
+
+[assembly: ExportEffect(typeof(ContentDescriptionEffectRenderer), ContentDescriptionEffect.EffectName)]
+namespace Xamarin.Forms.ControlGallery.Android
+{
+	public class ContentDescriptionEffectRenderer : PlatformEffect
+	{
+
+		protected override void OnAttached()
+		{
+		}
+
+		protected override void OnDetached()
+		{
+		}
+
+		protected override void OnElementPropertyChanged(PropertyChangedEventArgs args)
+		{
+			var button = Element as Button;
+			var viewGroup = Control as AViews.ViewGroup;
+			var nativeButton = Control as AWidget.Button;
+
+			if (nativeButton != null && viewGroup != null && viewGroup.ChildCount > 0)
+			{
+				nativeButton = viewGroup.GetChildAt(0) as AWidget.Button;
+			}
+
+			if (button == null || nativeButton == null)
+			{
+				return;
+			}
+
+			button.SetValue(
+				ContentDescriptionEffectProperties.ContentDescriptionProperty,
+				nativeButton.ContentDescription);
+		}
+
+	}
+}

Xamarin.Forms.ControlGallery.Android/Xamarin.Forms.ControlGallery.Android.csproj

@@ -121,6 +121,7 @@
     <Compile Include="_58406EffectRenderer.cs" />
     <Compile Include="_59457CustomRenderer.cs" />
     <Compile Include="_60122ImageRenderer.cs" />
+    <Compile Include="ContentDescriptionEffectRenderer.cs" />
     <Compile Include="..\Xamarin.Forms.Controls\GalleryPages\OpenGLGalleries\AdvancedOpenGLGallery.cs">
       <Link>GalleryPages\AdvancedOpenGLGallery.cs</Link>
     </Compile>

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5150.cs

@@ -0,0 +1,113 @@
+using System;
+using System.ComponentModel;
+using Xamarin.Forms.CustomAttributes;
+using Xamarin.Forms.Internals;
+
+
+#if UITEST
+using CategoryAttribute = NUnit.Framework.CategoryAttribute;
+using Xamarin.Forms.Core.UITests;
+using Xamarin.UITest;
+using NUnit.Framework;
+#endif
+
+namespace Xamarin.Forms.Controls.Issues
+{
+
+	public static class ContentDescriptionEffectProperties
+	{
+		public static readonly BindableProperty ContentDescriptionProperty = BindableProperty.CreateAttached(
+			"ContentDescription",
+			typeof(string),
+			typeof(ContentDescriptionEffectProperties),
+			null,
+			propertyChanged: OnContentDescriptionChanged );
+
+		public static string GetContentDescription(BindableObject view)
+		{
+			return (string)view.GetValue(ContentDescriptionProperty);
+		}
+
+		public static void SetContentDescription(BindableObject view, string value)
+		{
+			view.SetValue(ContentDescriptionProperty, value);
+		}
+
+		static void OnContentDescriptionChanged(BindableObject bindable, object oldValue, object newValue)
+		{
+			System.Diagnostics.Debug.WriteLine($"Old value = {oldValue}, new value = {newValue}");
+		}
+	}
+
+	public class ContentDescriptionEffect : RoutingEffect
+	{
+		public const string EffectName = "ContentDescriptionEffect";
+
+		public ContentDescriptionEffect() : base($"{Issues.Effects.ResolutionGroupName}.{EffectName}")
+		{
+		}
+	}
+
+#if UITEST
+	[Category(UITestCategories.Button)]
+#endif
+	[Preserve(AllMembers = true)]
+	[Issue(IssueTracker.Github, 5150, "AutomationProperties.Name, AutomationProperties.HelpText on Button not read by Android TalkBack", PlatformAffected.Android)]
+	public class Issue5150 : TestContentPage // or TestMasterDetailPage, etc ...
+	{
+
+		private void Configure(Button button, Label label, StackLayout layout, string buttonText, string buttonName = null, string buttonHelp = null)
+		{
+			button.Text = buttonText;
+			button.Effects.Add(new ContentDescriptionEffect());
+			button.SetValue(AutomationProperties.NameProperty, buttonName);
+			button.SetValue(AutomationProperties.HelpTextProperty, buttonHelp);
+			button.PropertyChanged += (object sender, PropertyChangedEventArgs e) => {
+				if (e.PropertyName == ContentDescriptionEffectProperties.ContentDescriptionProperty.PropertyName)
+				{
+					var element = sender as Button;
+					var desc = (string)element.GetValue(ContentDescriptionEffectProperties.ContentDescriptionProperty);
+					label.Text = desc;
+				}
+			};
+			layout.Children.Add(button);
+			layout.Children.Add(label);
+		}
+
+		protected override void Init()
+		{
+			var layout = new StackLayout();
+
+			var ButtonWithTextAndName = new Button();
+			var ButtonWithTextAndNameLabel = new Label();
+			Configure(ButtonWithTextAndName, ButtonWithTextAndNameLabel, layout, "Button 1", buttonName: "Name 1");
+
+			var ButtonWithTextAndHelp = new Button();
+			var ButtonWithTextAndHelpLabel = new Label();
+			Configure(ButtonWithTextAndHelp, ButtonWithTextAndHelpLabel, layout, "Button 2", buttonHelp: "Help 2.");
+
+			var ButtonWithTextAndNameAndHelp = new Button();
+			var ButtonWithTextAndNameAndHelpLabel = new Label();
+			Configure(ButtonWithTextAndNameAndHelp, ButtonWithTextAndNameAndHelpLabel, layout, "Button 3", "Name 3", "Help 3.");
+
+			Content = layout;
+		}
+
+#if UITEST
+		[Test]
+		public void Issue5150Test() 
+		{
+			RunningApp.Screenshot ("I am at Issue 5150");
+
+			RunningApp.WaitForElement (q => q.Text("Name 1"));
+			RunningApp.Screenshot ("I see the label Name 1");
+
+			RunningApp.WaitForElement(q => q.Text("Button 2. Help 2."));
+			RunningApp.Screenshot("I see the label Button 2. Help 2.");
+
+			RunningApp.WaitForElement(q => q.Text("Name 3. Help 3."));
+			RunningApp.Screenshot("I see the label Name 3. Help 3.");
+		}
+#endif
+	}
+}

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

@@ -881,6 +881,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)Issue4138.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Issue4314.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Issue3318.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)Issue5150.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Issue5172.cs" />
   </ItemGroup>
   <ItemGroup>
@@ -1101,4 +1102,4 @@
       <Generator>MSBuild:Compile</Generator>
     </EmbeddedResource>
   </ItemGroup>
-</Project>
+</Project>

Xamarin.Forms.Platform.Android/FastRenderers/AutomationPropertiesProvider.cs

@@ -55,6 +55,17 @@ internal static void SetBasicContentDescription(
 				defaultContentDescription = control.ContentDescription;
 
 			string value = ConcatenateNameAndHelpText(element);
+
+			var button = element as Button;
+			if (button != null)
+			{
+				var viewGroup = control as global::Android.Views.ViewGroup;
+				if (viewGroup != null)
+				{
+					control = viewGroup.GetChildAt(0);
+				}
+			}
+
 			control.ContentDescription = !string.IsNullOrWhiteSpace(value) ? value : defaultContentDescription;
 		}
 
@@ -191,12 +202,17 @@ bool SetHint()
 
 		internal static string ConcatenateNameAndHelpText(BindableObject Element)
 		{
+			var button = Element as Button;
+
+			var text = button?.Text;
 			var name = (string)Element.GetValue(AutomationProperties.NameProperty);
 			var helpText = (string)Element.GetValue(AutomationProperties.HelpTextProperty);
 
-			if (string.IsNullOrWhiteSpace(name))
+			if (!string.IsNullOrWhiteSpace(text) && string.IsNullOrWhiteSpace(name))
+				name = text;
+			else if (string.IsNullOrWhiteSpace(name))
 				return helpText;
-			if (string.IsNullOrWhiteSpace(helpText))
+			else if (string.IsNullOrWhiteSpace(helpText))
 				return name;
 
 			return $"{name}. {helpText}";