[Android] TalkBack now reads name and helptext on buttons. #5237

ryl · 2019-02-13T16:17:41Z

Description of Change

Modified AutomationPropertiesProvider such that AutomationProperties.Name and AutomationProperties.HelpText will be read by TalkBack.

Issues Resolved

fixes AutomationProperties.Name, AutomationProperties.HelpText on Button not read by Android TalkBack #5150
fixes [Android] Using AutomationId prevents TalkBack screenreader accessibility #1529

API Changes

None

Platforms Affected

Android

Behavioral/Visual Changes

TalkBack will read AutomationProperties.Name and AutomationProperties.HelpText on a button if provided.

Before/After Screenshots

Not applicable

Testing Procedure

In the Control Gallery, visit G5150. Labels containing the ContentDescription for each button should appear with appropriate text.

PR Checklist

Has automated tests
Rebased on top of the target branch at time of PR
Changes adhere to coding standard

dnfclas · 2019-02-13T16:17:54Z

All CLA requirements met.

ryl · 2019-02-13T22:00:53Z

I followed the instructions here https://blog.xamarin.com/beginners-guide-contributing-xamarin-forms/ more or less.

Are there any instructions I can follow to run a specific UI test, or all of them, using VS Mac? I have not actually tried my UI Test case.

Xamarin.Forms.Platform.Android/FastRenderers/AutomationPropertiesProvider.cs

paymicro

Looks good.
A few comments on the test

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5150.cs

paymicro

LGTM

samhouts · 2019-03-18T21:08:02Z

Xamarin.Forms.Platform.Android/FastRenderers/AutomationPropertiesProvider.cs

@@ -55,6 +55,10 @@ internal static void SetAutomationId(AView control, VisualElement element, strin
 				defaultContentDescription = control.ContentDescription;

 			string value = ConcatenateNameAndHelpText(element);
+
+			if (control is IButtonLayoutRenderer button)


I think we're going to have to revisit this later, since this is only fixing the issue for Buttons, and it now likely affecting other controls, too. This can work for now, though. Thanks!

samhouts

Issue5150 test doesn't work on iOS :( Need to either make it work or make it only run on Android. :)

samhouts · 2019-03-19T03:13:18Z

Also, UI test is now unable to find the Buttons on Android at all. Not good!

ryl · 2019-03-20T19:54:55Z

How would I go about making the UI Test only run only on Android? This is my first attempt at contributing so I'm pretty green on procedures. I took a look at another issuse (3415) that seems to be Android only and didn't see anything remarkably different between that and my test. If you can point me in the right direction I'll try to get it polished up.

ryl · 2019-03-21T18:26:28Z

I did some more digging around and found some tests that were using [Ignore] for certain platforms. I added it to 5150's UI Test. It should only run on the Android platform now. Since the bug/fix only applies to Android, that seems like the way to go to me.

ryl · 2019-03-29T13:56:32Z

Also, UI test is now unable to find the Buttons on Android at all. Not good!

I see what you're saying about not being able to find buttons. Looking through the core tests it looks like this fix breaks AutomationId, which seems to come back to #1529.

Seems that AutomationId and Name + HelpText are competing for use of ContentDescription.

…amarin#5349 * RadioButton * Removed unused files * Rebase and make it run * First round of feedback * Revert AppCompatButton -> AButton * Cleaned minor usings * Fix unselecting radiobutton on iOS * Fixed Mac OS grouping * [Android] Fix API29 usages Co-authored-by: Andrei Nitescu <[email protected]> Co-authored-by: Rui Marinho <[email protected]>

…amarin#9187) * Fix BottomNavigationItemView with MasterDetailPage. * Added repro sample Co-authored-by: Javier Suárez Ruiz <[email protected]> fixes xamarin#9143

* Add a platform test to check for Bugzilla 35738 * Delete the Bugzilla35738 UI test * Bold the start of fixtures Fix typo * Add some background color tests for iOS * Add test for iOS Button BackgroundColor * Remove changes to PerformanceTrackerRenderer * Split classes into files * Add UWP testing platform * Cache default font size * Run UWP tests on main thread * Use GetOrCreateRenderer * Split Test and Description attributes; clean up iOS background color tests * Opacity tests on iOS * Some background color tests for UWP * BackgroundColorTests for UWP for most controls * Shortcut key to get to platform tests on UWP * Button background color test for Android * BackgroundColor tests for Android controls * Opacity tests for Android * Ignore Opacity tests for iOS/Android (replaced by platform tests) * Remove unused empty BackgroundColor test * IsEnabled tests for Android * Consolidate basic VisualElement list * Apply categories for generate test cases * Consolidate element list * IsEnabled tests for iOS * Ignore tests covered by platform tests * Fix incorrect overrides * Rotation tests for Android * Rotation tests for iOS * Set UI test versions to Ignore * Rotation tests for UWP * Scale tests for iOS * ScaleX and ScaleY tests for Android * Android TranslationX and TranslationY tests * Ignore TranslationX/Y for manual review on Android * Ignore tests covered by platform tests * Add Sliders to the Android/iOS tests * Add Slider to UWP tests * Ignore tests for Slider that're already covered * Add ImageButton to the platform tests * Ignore duplicate tests for ImageButton * Add IsVisible tests for Android/iOS * Ignore IsVisible tests covered by platform tests * Fix usings for AndroidX * BoxView tests for Android * Add test counter to platform test console * BoxView tests for iOS * Ignore duplicate tests for BoxView * Frame tests for Android * Add Frame tests on iOS * Ignore duplicate tests * Add Button and Label text tests for Android/iOS * Ignore duplicate text test for Button * Add more controls to UWP tests; add IsEnabled tests for UWP * Add scale tests for UWP * Ignore UWP tests covered by platform tests * Mark Issue968 test as manual review * Replace 8269 UI test with platform test * Move 8682 from UI test to platform test * Mark Issue8004 test for manual review * Adding manual review attribute for Bugzilla29128 * Show bitmaps for failed color tests on Android; create BoxView CornerRadius test * Functional color-at-point tests * Clean up Android pixel checking code; add more CornerRadius tests * Fix NRE in FrameRenderer * Ignore Frame * Fix cross-thread dispose issues with StepperRenderer and SliderRenderer * Add tolerance for color comparisons * Parent Frame for older API versions * Remove assertion not supported before iOS 12 * Address fast label renderer, changes in BoxView, and a bug in Android fast button

# Conflicts: # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems # Xamarin.Forms.Platform.Android/FastRenderers/AutomationPropertiesProvider.cs # Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj

ryl · 2020-02-26T17:30:00Z

@samhouts I accidentally deleted my pull request branch when I meant to do a force push to resolve some conflicts. Any chance I can get this re-opened, or should I just create a new one?

samhouts · 2020-02-26T17:44:53Z

Oops! Looks like you're going to need to create a new one. I don't have the ability to reopen it.

samhouts added p/Android a/a11y 🔍 labels Feb 13, 2019

samhouts changed the title ~~Fix for 5150. TalkBack now reads name and helptext on buttons.~~ [Android] TalkBack now reads name and helptext on buttons. Feb 14, 2019

[Android] TalkBack now reads name and helptext on buttons.

5fcc2c4

ryl force-pushed the automation-name-helptext branch from 6cfbf26 to 5fcc2c4 Compare February 17, 2019 03:40

Merge branch 'master' into automation-name-helptext

a778196

samhouts requested review from paymicro and samhouts February 19, 2019 17:47

samhouts assigned paymicro and samhouts Feb 19, 2019

paymicro suggested changes Feb 25, 2019

View reviewed changes

ryl added 2 commits March 9, 2019 13:14

Merge branch 'master' into automation-name-helptext

1cc5905

Updates based on feedback.

fad3863

samhouts requested a review from paymicro March 11, 2019 19:09

paymicro reviewed Mar 12, 2019

View reviewed changes

simplification of uitest

cafc793

paymicro approved these changes Mar 12, 2019

View reviewed changes

samhouts added the t/bug 🐛 label Mar 18, 2019

Merge branch 'master' into automation-name-helptext

afb3c9c

samhouts approved these changes Mar 18, 2019

View reviewed changes

samhouts suggested changes Mar 19, 2019

View reviewed changes

Only execute 5150 UI Test on the Android platform.

647c700

paymicro requested a review from samhouts March 25, 2019 09:34

Work around AutomationId.

81494ff

samhouts removed the i/critical label Feb 13, 2020

PureWeen and others added 12 commits February 14, 2020 15:50

Merge branch '4.5.0'

6a23b84

Fix unbalanced performance start/stop call. (xamarin#8622)

08007a8

FormsFontIcon added (xamarin#9587)

c5bea02

Merge branch '4.5.0'

758bdd3

[WPF] Fix typo

728e41d

[Android] Fix BottomNavigationItemView issue with MasterDetailPage (x…

a796678

…amarin#9187) * Fix BottomNavigationItemView with MasterDetailPage. * Added repro sample Co-authored-by: Javier Suárez Ruiz <[email protected]> fixes xamarin#9143

Merge branch '4.5.0'

17a0497

Update VS 2015 -> Visual Studio for Windows (xamarin#9643)

6a41de3

Merge branch '4.5.0'

adc0987

[WPF] Fix typo

f30d423

Merge branch '4.5.0'

0eade95

ryl mentioned this pull request Feb 21, 2020

[Enhancement] Xamarin Does Not Feel Production Ready in Terms of A11y #9670

Closed

hartez and others added 4 commits February 21, 2020 16:54

Updated to support AndroidX packages.

d3d45a8

Matching master.

164d0a3

ryl requested a review from StephaneDelcroix as a code owner February 26, 2020 16:48

samhouts added p/iOS 🍎 a/maps 🌐 p/UWP p/macOS p/WPF a/visual labels Feb 26, 2020

ryl closed this Feb 26, 2020

ryl deleted the automation-name-helptext branch February 26, 2020 17:19

ryl mentioned this pull request Feb 26, 2020

[Android] TalkBack now reads name and helptext on buttons. #9728

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] TalkBack now reads name and helptext on buttons. #5237

[Android] TalkBack now reads name and helptext on buttons. #5237

ryl commented Feb 13, 2019 •

edited by samhouts

Loading

dnfclas commented Feb 13, 2019 •

edited

Loading

ryl commented Feb 13, 2019

paymicro left a comment

paymicro left a comment

samhouts Mar 18, 2019

samhouts left a comment

samhouts commented Mar 19, 2019

ryl commented Mar 20, 2019

ryl commented Mar 21, 2019 •

edited

Loading

ryl commented Mar 29, 2019

ryl commented Feb 26, 2020

samhouts commented Feb 26, 2020

[Android] TalkBack now reads name and helptext on buttons. #5237

[Android] TalkBack now reads name and helptext on buttons. #5237

Conversation

ryl commented Feb 13, 2019 • edited by samhouts Loading

Description of Change

Issues Resolved

API Changes

Platforms Affected

Behavioral/Visual Changes

Before/After Screenshots

Testing Procedure

PR Checklist

dnfclas commented Feb 13, 2019 • edited Loading

ryl commented Feb 13, 2019

paymicro left a comment

Choose a reason for hiding this comment

paymicro left a comment

Choose a reason for hiding this comment

samhouts Mar 18, 2019

Choose a reason for hiding this comment

samhouts left a comment

Choose a reason for hiding this comment

samhouts commented Mar 19, 2019

ryl commented Mar 20, 2019

ryl commented Mar 21, 2019 • edited Loading

ryl commented Mar 29, 2019

ryl commented Feb 26, 2020

samhouts commented Feb 26, 2020

ryl commented Feb 13, 2019 •

edited by samhouts

Loading

dnfclas commented Feb 13, 2019 •

edited

Loading

ryl commented Mar 21, 2019 •

edited

Loading