Skip to content
This repository was archived by the owner on Oct 24, 2024. It is now read-only.

add basic ci setup #20

Merged
merged 4 commits into from
Aug 25, 2021
Merged

add basic ci setup #20

merged 4 commits into from
Aug 25, 2021

Conversation

jhamman
Copy link

@jhamman jhamman commented Aug 25, 2021

No description provided.

@jhamman
Copy link
Author

jhamman commented Aug 25, 2021

@TomNicholas - this is probably ready to go. The remaining failure is just the pre-commit linter, which I've borrowed from Xarray. Options are:

  1. turn it off for now
  2. merge with the failure and do a second pr with a big lint-only change log
  3. I can run pre-commit as part of this PR and the tests will pass.

@TomNicholas
Copy link
Member

Thank you very much @jhamman !

I would prefer option (2), because I want to make sure my linters work locally - I haven't been using them on this project beyond pycharm's default features yet - I put pre-commit in the dependencies aspirationally 😅 If they are the same ones as xarray it should work fine though.

Would you like write access to this repo or shall I just merge it now?

@jhamman
Copy link
Author

jhamman commented Aug 25, 2021

Happy to just have you merge for now. Go for it when you are ready.

@TomNicholas TomNicholas merged commit c5df4d5 into xarray-contrib:main Aug 25, 2021
flamingbear pushed a commit to flamingbear/rewritten-datatree that referenced this pull request Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants