-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
@keewis that caused a bunch of |
I guess that's because |
Frozen is an xarray internals class, so we could add the |
I agree, we can't make use of that for now. However, Otherwise let's revert that change. Edit: reverting seems easiest, so I did that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge!
* merge two dictionaries using dictionary unpacking * check that the fix actually worked * use `|` to combine two dictionaries * Revert "use `|` to combine two dictionaries" This reverts commit ecfbbd55dc687ac5b2bb582cd3d29a4afc3608e4. --------- Co-authored-by: Tom Nicholas <[email protected]>
Another option would be the python 3.9-only
dict1 | dict2
(which involves fewer special chars and thus I find it easier to read).parent
of new nodes is not assigned properly inupdate
#203pre-commit run --all-files