Skip to content
This repository was archived by the owner on Oct 24, 2024. It is now read-only.

update using dictionary unpacking #213

Merged
merged 7 commits into from
Feb 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datatree/datatree.py
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ def update(self, other: Dataset | Mapping[str, DataTree | DataArray]) -> None:

vars_merge_result = dataset_update_method(self.to_dataset(), new_variables)
# TODO are there any subtleties with preserving order of children like this?
merged_children = OrderedDict(**self.children, **new_children)
merged_children = OrderedDict({**self.children, **new_children})
self._replace(
inplace=True, children=merged_children, **vars_merge_result._asdict()
)
Expand Down
11 changes: 11 additions & 0 deletions datatree/tests/test_datatree.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,17 @@ def test_update_doesnt_alter_child_name(self):
child = dt["a"]
assert child.name == "a"

def test_update_overwrite(self):
actual = DataTree.from_dict({"a": DataTree(xr.Dataset({"x": 1}))})
actual.update({"a": DataTree(xr.Dataset({"x": 2}))})

expected = DataTree.from_dict({"a": DataTree(xr.Dataset({"x": 2}))})

print(actual)
print(expected)

dtt.assert_equal(actual, expected)


class TestCopy:
def test_copy(self, create_test_datatree):
Expand Down