Skip to content

24-3: schemeshard: fix enable_alter_database_create_hive_first mode #10098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Oct 4, 2024

Storage pools duplication (in memory only) happened at the first database alter (first alter is actually constructs the database) causes StatusInvalidParameter errors for the next alters if they repeat storage pools specification. Ydbcp does exactly that and so databases created via ydbcp are displayed in the webui as having CONFIGURING state instead of RUNNING.

Databases stuck in that state are actually fully functional, but still are not being able to execute some alters until root schemeshard is rebooted.

KIKIMR-10367
YDBOPS-7628

Changelog entry

Fix alter-extsubdomain behaviour that could prevent some database alters from executing when enable_alter_database_create_hive_first feature flag is enabled.

Changelog category

  • Bugfix

…atform#10074)

Storage pools duplication (in memory only) happened at the first database alter (first alter is actually constructs the database) causes StatusInvalidParameter errors for the next alters if they repeat storage pools specification. Ydbcp does exactly that and so databases created via ydbcp are displayed in the webui as having CONFIGURING state instead of RUNNING.

Databases stuck in that state are actually fully functional, but still are not being able to execute some alters until root schemeshard is rebooted.

KIKIMR-10367
YDBOPS-7628
@ijon ijon requested a review from a team as a code owner October 4, 2024 12:56
Copy link

github-actions bot commented Oct 4, 2024

2024-10-04 12:59:46 UTC Pre-commit check for 214207a has started.
2024-10-04 13:02:18 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-04 13:09:16 UTC Build successful.

Copy link

github-actions bot commented Oct 4, 2024

2024-10-04 13:00:17 UTC Pre-commit check for 214207a has started.
2024-10-04 13:03:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-04 13:41:57 UTC Build successful.
2024-10-04 13:42:12 UTC Tests are running...
🔴 2024-10-04 15:07:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14370 13020 0 5 1299 46

🟢 2024-10-04 15:08:18 UTC ydbd size 8.2 GiB changed* by +896 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6508540 merge: 214207a diff diff %
ydbd size 8 805 545 168 Bytes 8 805 546 064 Bytes +896 Bytes +0.000%
ydbd stripped size 480 069 544 Bytes 480 069 736 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 4, 2024

2024-10-04 13:00:31 UTC Pre-commit check for 214207a has started.
2024-10-04 13:03:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-04 13:26:05 UTC Build successful.
2024-10-04 13:26:19 UTC Tests are running...
🔴 2024-10-04 15:28:34 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10069 9979 0 20 26 44

🟢 2024-10-04 15:29:12 UTC ydbd size 5.6 GiB changed* by +1.2 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6508540 merge: 214207a diff diff %
ydbd size 5 962 075 736 Bytes 5 962 076 928 Bytes +1.2 KiB +0.000%
ydbd stripped size 1 491 985 472 Bytes 1 491 985 984 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon merged commit dcbe1a9 into ydb-platform:stable-24-3 Oct 4, 2024
8 of 12 checks passed
@ijon ijon deleted the merge/24-3/fix-enable-alter-database-create-hive-first branch October 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants