Skip to content

[docs] consolidate the coordination nodes content #12314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 8, 2024
Merged

[docs] consolidate the coordination nodes content #12314

merged 7 commits into from
Dec 8, 2024

Conversation

blinkov
Copy link
Member

@blinkov blinkov commented Dec 5, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Documentation (changelog entry is not required)

Additional information

Supersedes #7657

@blinkov blinkov requested a review from a team as a code owner December 5, 2024 11:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 5, 2024
@blinkov blinkov enabled auto-merge (squash) December 5, 2024 11:10
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Dec 5, 2024
@blinkov blinkov requested a review from asmyasnikov December 5, 2024 11:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

⚪ 2024-12-05 11:10:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for c7c86bb has started.
⚪ 2024-12-05 11:11:11 UTC Artifacts will be uploaded here
⚪ 2024-12-05 11:13:36 UTC ya make is running...
🟢 2024-12-05 11:15:00 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-05 11:15:05 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

⚪ 2024-12-05 11:11:05 UTC Pre-commit check linux-x86_64-release-asan for c7c86bb has started.
⚪ 2024-12-05 11:11:19 UTC Artifacts will be uploaded here
⚪ 2024-12-05 11:13:52 UTC ya make is running...
🟢 2024-12-05 11:15:27 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-05 11:15:33 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov requested review from snaury and alex268 December 5, 2024 11:15
snaury
snaury previously approved these changes Dec 5, 2024
View reviewed changes
alex268
alex268 previously approved these changes Dec 5, 2024
View reviewed changes
@asmyasnikov asmyasnikov dismissed stale reviews from alex268 and snaury via 0da0b89 December 6, 2024 10:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

⚪ 2024-12-06 10:11:24 UTC Pre-commit check linux-x86_64-release-asan for d24644b has started.
⚪ 2024-12-06 10:11:35 UTC Artifacts will be uploaded here
⚪ 2024-12-06 10:13:59 UTC ya make is running...
🔴 2024-12-06 10:14:31 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

⚪ 2024-12-06 10:12:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for d24644b has started.
⚪ 2024-12-06 10:12:40 UTC Artifacts will be uploaded here
⚪ 2024-12-06 10:15:05 UTC ya make is running...
🔴 2024-12-06 10:15:41 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

❌ Documentation build

Revision build failed

Build logs

Errors (1)

❌ /en/reference/ydb-sdk/coordination.md: 213: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```go"]

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

⚪ 2024-12-06 14:25:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3b512a3 has started.
⚪ 2024-12-06 14:26:03 UTC Artifacts will be uploaded here
⚪ 2024-12-06 14:28:29 UTC ya make is running...
🔴 2024-12-06 14:29:03 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

⚪ 2024-12-06 14:26:30 UTC Pre-commit check linux-x86_64-release-asan for 3b512a3 has started.
⚪ 2024-12-06 14:26:41 UTC Artifacts will be uploaded here
⚪ 2024-12-06 14:29:20 UTC ya make is running...
🔴 2024-12-06 14:29:58 UTC Build failed, see the logs. Also see fail summary
⚫ 2024-12-06 14:30:03 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

❌ Documentation build

Revision build failed

Build logs

Errors (1)

❌ /en/reference/ydb-sdk/coordination.md: 207: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```go"]

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

⚪ 2024-12-06 14:33:59 UTC Pre-commit check linux-x86_64-release-asan for 58540e1 has started.
⚪ 2024-12-06 14:34:10 UTC Artifacts will be uploaded here
⚪ 2024-12-06 14:36:36 UTC ya make is running...
🟢 2024-12-06 14:37:56 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-06 14:38:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

⚪ 2024-12-06 14:34:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 58540e1 has started.
⚪ 2024-12-06 14:34:20 UTC Artifacts will be uploaded here
⚪ 2024-12-06 14:36:52 UTC ya make is running...
🟢 2024-12-06 14:38:22 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-06 14:38:29 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov merged commit bae1ca8 into main Dec 8, 2024
12 checks passed
This was referenced Dec 10, 2024
Closed
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Dec 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmyasnikov asmyasnikov asmyasnikov left review comments

@fomichev3000 fomichev3000 fomichev3000 approved these changes

@snaury snaury snaury left review comments

@alex268 alex268 alex268 left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blinkov @snaury @fomichev3000 @asmyasnikov @alex268