Skip to content

Optimize CPU usage when read blob (always use count limit) #12349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nshestakov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 09:21:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for ecbf8f1 has started.
2024-12-06 09:21:21 UTC Artifacts will be uploaded here
2024-12-06 09:24:24 UTC ya make is running...
🟡 2024-12-06 10:47:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21003 19423 0 3 1463 114

2024-12-06 10:49:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-06 11:01:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
719 (only retried tests) 611 0 1 1 106

2024-12-06 11:01:25 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-06 11:13:39 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
623 (only retried tests) 516 0 1 0 106

🟢 2024-12-06 11:13:50 UTC Build successful.
🟢 2024-12-06 11:14:12 UTC ydbd size 2.5 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2fa847a merge: ecbf8f1 diff diff %
ydbd size 2 699 025 048 Bytes 2 699 024 936 Bytes -112 Bytes -0.000%
ydbd stripped size 483 486 064 Bytes 483 486 064 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 09:22:50 UTC Pre-commit check linux-x86_64-release-asan for ecbf8f1 has started.
2024-12-06 09:23:26 UTC Artifacts will be uploaded here
2024-12-06 09:26:48 UTC ya make is running...
🟡 2024-12-06 10:54:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13286 13216 0 21 5 44

🟢 2024-12-06 10:55:59 UTC Build successful.
🟢 2024-12-06 10:56:25 UTC ydbd size 4.9 GiB changed* by -1.3 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 50445e3 merge: ecbf8f1 diff diff %
ydbd size 5 306 569 064 Bytes 5 305 250 568 Bytes -1.3 MiB -0.025%
ydbd stripped size 1 365 896 752 Bytes 1 365 527 600 Bytes -360.5 KiB -0.027%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 12:55:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for d02c82a has started.
2024-12-06 12:56:09 UTC Artifacts will be uploaded here
2024-12-06 12:59:02 UTC ya make is running...
🟡 2024-12-06 13:54:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21003 19484 0 1 1408 110

2024-12-06 13:56:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-06 14:08:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
656 (only retried tests) 548 0 1 0 107

2024-12-06 14:08:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-06 14:20:36 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
644 (only retried tests) 536 0 1 0 107

🟢 2024-12-06 14:20:45 UTC Build successful.
🟢 2024-12-06 14:21:06 UTC ydbd size 2.5 GiB changed* by -192 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 17066f1 merge: d02c82a diff diff %
ydbd size 2 699 201 576 Bytes 2 699 201 384 Bytes -192 Bytes -0.000%
ydbd stripped size 483 500 720 Bytes 483 500 656 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 12:57:11 UTC Pre-commit check linux-x86_64-release-asan for d02c82a has started.
2024-12-06 12:57:23 UTC Artifacts will be uploaded here
2024-12-06 13:00:16 UTC ya make is running...
🟡 2024-12-06 14:12:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13286 13193 0 35 11 47

🟢 2024-12-06 14:13:59 UTC Build successful.
🟢 2024-12-06 14:14:28 UTC ydbd size 4.9 GiB changed* by -1.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 17066f1 merge: d02c82a diff diff %
ydbd size 5 305 570 352 Bytes 5 305 569 200 Bytes -1.1 KiB -0.000%
ydbd stripped size 1 365 574 736 Bytes 1 365 574 416 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Dec 6, 2024
@nshestakov nshestakov enabled auto-merge (squash) December 6, 2024 13:18
Copy link

github-actions bot commented Dec 7, 2024

2024-12-07 04:48:55 UTC Pre-commit check linux-x86_64-release-asan for 0f1bb06 has started.
2024-12-07 04:49:08 UTC Artifacts will be uploaded here
2024-12-07 04:52:02 UTC ya make is running...
🟡 2024-12-07 06:23:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13297 13215 0 18 17 47

🟢 2024-12-07 06:24:57 UTC Build successful.
🟢 2024-12-07 06:25:24 UTC ydbd size 4.9 GiB changed* by -1.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6b63b7d merge: 0f1bb06 diff diff %
ydbd size 5 305 965 960 Bytes 5 305 964 808 Bytes -1.1 KiB -0.000%
ydbd stripped size 1 365 628 240 Bytes 1 365 627 920 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 7, 2024

2024-12-07 04:49:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0f1bb06 has started.
2024-12-07 04:49:29 UTC Artifacts will be uploaded here
2024-12-07 04:52:24 UTC ya make is running...
🟡 2024-12-07 05:42:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21014 19492 0 1 1408 113

2024-12-07 05:44:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-07 05:56:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
660 (only retried tests) 553 0 1 0 106

2024-12-07 06:11:30 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-07 06:23:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
633 (only retried tests) 527 0 0 0 106

🟢 2024-12-07 06:23:21 UTC Build successful.
🟢 2024-12-07 06:23:44 UTC ydbd size 2.5 GiB changed* by -128 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6b63b7d merge: 0f1bb06 diff diff %
ydbd size 2 699 421 808 Bytes 2 699 421 680 Bytes -128 Bytes -0.000%
ydbd stripped size 483 524 944 Bytes 483 524 944 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov merged commit 751da8a into ydb-platform:main Dec 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants