Skip to content

fix SendChannelData(): requirement !outputChannel.RetryState in async CA #15338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2025
Merged

fix SendChannelData(): requirement !outputChannel.RetryState in async CA #15338

merged 4 commits into from
Mar 10, 2025

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Mar 4, 2025

In async CA channel can enter retry state between check for CanSendChannelData and call to SendChannelData.
Regression by c318914

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@yumkam
fix SendChannelData(): requirement !outputChannel.RetryState in async CA
db3d86f 
In async CA channel can enter retry state between check for
CanSendChannelData and call to SendChannelData.
Regression by c318914
@yumkam yumkam marked this pull request as ready for review March 4, 2025 21:38
@yumkam yumkam requested review from a team as code owners March 4, 2025 21:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

🟢 2025-03-04 21:41:10 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 21:43:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 147b87c has started.
⚪ 2025-03-04 21:43:29 UTC Artifacts will be uploaded here
⚪ 2025-03-04 21:46:11 UTC ya make is running...
⚫ 2025-03-04 21:48:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 21:43:22 UTC Pre-commit check linux-x86_64-release-asan for 147b87c has started.
⚪ 2025-03-04 21:43:37 UTC Artifacts will be uploaded here
⚪ 2025-03-04 21:46:28 UTC ya make is running...
⚫ 2025-03-04 21:48:02 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 21:55:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 694c812 has started.
⚪ 2025-03-04 21:56:05 UTC Artifacts will be uploaded here
⚪ 2025-03-04 21:58:51 UTC ya make is running...
🟡 2025-03-04 22:51:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26213 23615 0 2 2478 118

⚪ 2025-03-04 22:53:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-04 23:07:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 76 0 0 0 105

🟢 2025-03-04 23:07:53 UTC Build successful.
🟢 2025-03-04 23:08:12 UTC ydbd size 2.1 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fb4d6bb merge: 694c812 diff diff %
ydbd size 2 290 063 784 Bytes 2 290 066 104 Bytes +2.3 KiB +0.000%
ydbd stripped size 479 946 656 Bytes 479 947 168 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 21:55:49 UTC Pre-commit check linux-x86_64-release-asan for 694c812 has started.
⚪ 2025-03-04 21:56:04 UTC Artifacts will be uploaded here
⚪ 2025-03-04 21:58:53 UTC ya make is running...
🟡 2025-03-04 23:09:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11852 11543 0 253 22 34

⚪ 2025-03-04 23:10:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 23:27:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
376 (only retried tests) 336 0 8 1 31

⚪ 2025-03-04 23:27:26 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-04 23:39:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 38 0 0 0 30

🟢 2025-03-04 23:39:35 UTC Build successful.
🟢 2025-03-04 23:40:03 UTC ydbd size 3.7 GiB changed* by +3.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fb4d6bb merge: 694c812 diff diff %
ydbd size 3 990 832 800 Bytes 3 990 836 752 Bytes +3.9 KiB +0.000%
ydbd stripped size 1 388 981 064 Bytes 1 388 982 216 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 10:02:10 UTC Pre-commit check linux-x86_64-release-asan for 42f6957 has started.
⚪ 2025-03-05 10:02:24 UTC Artifacts will be uploaded here
⚪ 2025-03-05 10:05:16 UTC ya make is running...
🟡 2025-03-05 11:11:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11873 11724 0 89 27 33

⚪ 2025-03-05 11:12:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-05 11:31:32 UTC ydbd size 3.7 GiB changed* by -5.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd3b066 merge: 42f6957 diff diff %
ydbd size 3 990 867 248 Bytes 3 990 861 352 Bytes -5.8 KiB -0.000%
ydbd stripped size 1 388 994 440 Bytes 1 388 993 544 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-03-05 11:31:33 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 10:02:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 42f6957 has started.
⚪ 2025-03-05 10:02:59 UTC Artifacts will be uploaded here
⚪ 2025-03-05 10:05:53 UTC ya make is running...
🟡 2025-03-05 11:03:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26233 23633 0 3 2469 128

⚪ 2025-03-05 11:05:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-05 11:18:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 73 0 0 0 109

🟢 2025-03-05 11:19:01 UTC Build successful.
🟢 2025-03-05 11:19:21 UTC ydbd size 2.1 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4d0fb2e merge: 42f6957 diff diff %
ydbd size 2 290 081 512 Bytes 2 290 083 752 Bytes +2.2 KiB +0.000%
ydbd stripped size 479 951 680 Bytes 479 952 128 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 11:32:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc6dcd0 has started.
⚪ 2025-03-05 11:33:10 UTC Artifacts will be uploaded here
⚪ 2025-03-05 11:36:01 UTC ya make is running...
🟡 2025-03-05 12:35:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26235 23639 0 4 2470 122

⚪ 2025-03-05 12:37:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-05 12:48:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
183 (only retried tests) 76 0 0 0 107

🟢 2025-03-05 12:49:05 UTC Build successful.
🟡 2025-03-05 12:49:23 UTC ydbd size 2.1 GiB changed* by +139.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5a1e03d merge: fc6dcd0 diff diff %
ydbd size 2 290 085 376 Bytes 2 290 227 920 Bytes +139.2 KiB +0.006%
ydbd stripped size 479 952 640 Bytes 479 979 712 Bytes +26.4 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 11:33:25 UTC Pre-commit check linux-x86_64-release-asan for fc6dcd0 has started.
⚪ 2025-03-05 11:33:54 UTC Artifacts will be uploaded here
⚪ 2025-03-05 11:36:39 UTC ya make is running...
🟡 2025-03-05 12:43:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11875 11726 0 89 23 37

⚪ 2025-03-05 12:44:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 12:58:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 162 0 6 6 33

⚪ 2025-03-05 12:58:55 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-05 13:11:06 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72 (only retried tests) 40 0 0 0 32

🟢 2025-03-05 13:11:13 UTC Build successful.
🟡 2025-03-05 13:11:43 UTC ydbd size 3.7 GiB changed* by +271.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5a1e03d merge: fc6dcd0 diff diff %
ydbd size 3 990 863 936 Bytes 3 991 141 656 Bytes +271.2 KiB +0.007%
ydbd stripped size 1 388 994 760 Bytes 1 389 078 632 Bytes +81.9 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam merged commit d1391d4 into ydb-platform:main Mar 10, 2025
12 checks passed
@yumkam yumkam deleted the async-ca-fix-output-channel-Retry-State-assert branch March 10, 2025 15:06
yumkam added a commit to yumkam/ydb that referenced this pull request Mar 10, 2025
@yumkam
fix SendChannelData(): requirement !outputChannel.RetryState in async…
1514438 
… CA (ydb-platform#15338)

(cherry picked from commit d1391d4)
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
yumkam added a commit that referenced this pull request Mar 11, 2025
@yumkam
fix SendChannelData(): requirement !outputChannel.RetryState in async…
50d9f86 
… CA (backport #15338) (#15539)
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@yumkam @adameat
fix SendChannelData(): requirement !outputChannel.RetryState in async…
2d1907b 
… CA (ydb-platform#15338)
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@yumkam @blinkov
fix SendChannelData(): requirement !outputChannel.RetryState in async…
ae93fc6 
… CA (#15338)
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@yumkam
fix SendChannelData(): requirement !outputChannel.RetryState in async…
46fa52e 
… CA (ydb-platform#15338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

@uzhastik uzhastik uzhastik approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yumkam @vitstn @uzhastik