You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is already implemented in TBlockFuncNode::DoCalculate, so if the type annotation is invalid or a given Arrow Datum doesn't match the annotated type, the debug build will hit the assertion. This patch makes the Datum type check in TWideFromBlocksWrapper::TState::Get as strict as in TBlockFuncNode::DoCalculate.
⚪ 2024-04-25 08:16:35 UTC Pre-commit check for fd4aef4 has started.
⚪ 2024-04-25 08:16:38 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-25 08:23:19 UTC Build successful.
⚪ 2024-04-25 08:16:36 UTC Pre-commit check for fd4aef4 has started.
⚪ 2024-04-25 08:16:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-25 08:19:33 UTC Build successful.
⚪ 2024-04-25 08:21:20 UTC Tests are running...
🔴 2024-04-25 10:08:18 UTC Some tests failed, follow the links below.
⚪ 2024-04-25 08:16:40 UTC Pre-commit check for fd4aef4 has started.
⚪ 2024-04-25 08:16:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-25 08:20:15 UTC Build successful.
⚪ 2024-04-25 08:22:06 UTC Tests are running...
🔴 2024-04-25 10:17:35 UTC Some tests failed, follow the links below.
This check is already implemented in <TBlockFuncNode::DoCalculate>, so
if the type annotation is invalid or a given Arrow Datum doesn't match
the annotated type, the debug build will hit the assertion. This patch
makes the Datum type check in <TWideFromBlocksWrapper::TState::Get>
as strict as in <TBlockFuncNode::DoCalculate>.
Relates to #3485
⚪ 2024-05-02 18:31:04 UTC Pre-commit check for 177371f has started.
⚪ 2024-05-02 18:31:06 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-02 18:34:45 UTC Build successful.
⚪ 2024-05-02 18:31:15 UTC Pre-commit check for 177371f has started.
⚪ 2024-05-02 18:31:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-02 18:34:20 UTC Build successful.
⚪ 2024-05-02 18:36:07 UTC Tests are running...
🔴 2024-05-02 20:25:07 UTC Some tests failed, follow the links below.
⚪ 2024-05-02 18:31:18 UTC Pre-commit check for 177371f has started.
⚪ 2024-05-02 18:31:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-02 18:34:53 UTC Build successful.
⚪ 2024-05-02 18:36:40 UTC Tests are running...
🔴 2024-05-02 20:29:54 UTC Some tests failed, follow the links below.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
igormunkin
force-pushed
the
verify-input-datum-descr
branch
from
This check is already implemented in
TBlockFuncNode::DoCalculate, so if the type annotation is invalid or a given Arrow Datum doesn't match the annotated type, the debug build will hit the assertion. This patch makes the Datum type check inTWideFromBlocksWrapper::TState::Getas strict as inTBlockFuncNode::DoCalculate.Relates to #3485
Changelog category