Skip to content

Make Arrow Datum check message more verbose #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

igormunkin
Copy link
Collaborator

It's worth to provide both expected and got Arrow Datum types in the assertion message for convenient analysis.

Follows up #4096

Changelog category

  • Not for changelog (changelog entry is not required)

Copy link

github-actions bot commented May 6, 2024

2024-05-06 08:37:41 UTC Pre-commit check for e7d0784 has started.
2024-05-06 08:37:44 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-06 08:41:19 UTC Build successful.

Copy link

github-actions bot commented May 6, 2024

2024-05-06 08:37:50 UTC Pre-commit check for e7d0784 has started.
2024-05-06 08:37:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-06 08:40:53 UTC Build successful.
2024-05-06 08:42:39 UTC Tests are running...
🔴 2024-05-06 10:13:22 UTC Test run completed, no test results found for commit f88aec5. Please check build logs.
2024-05-06 10:13:25 UTC Check cancelled

Copy link

github-actions bot commented May 6, 2024

2024-05-06 08:38:01 UTC Pre-commit check for e7d0784 has started.
2024-05-06 08:38:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-06 08:41:21 UTC Build successful.
2024-05-06 08:43:04 UTC Tests are running...
🔴 2024-05-06 10:13:22 UTC Test run completed, no test results found for commit f88aec5. Please check build logs.
2024-05-06 10:13:26 UTC Check cancelled

It's worth to provide both expected and got Arrow Datum types in the
assertion message for convenient analysis.

Follows up #4096
@igormunkin igormunkin force-pushed the imun/enhance-diagnostic branch from f88aec5 to f18dcd5 Compare May 6, 2024 10:13
Copy link

github-actions bot commented May 6, 2024

2024-05-06 10:14:53 UTC Pre-commit check for 8533d2d has started.
2024-05-06 10:14:55 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-06 10:37:25 UTC Build successful.

Copy link

github-actions bot commented May 6, 2024

2024-05-06 10:16:40 UTC Pre-commit check for 8533d2d has started.
2024-05-06 10:16:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-06 10:39:04 UTC Build successful.
2024-05-06 10:40:48 UTC Tests are running...
🔴 2024-05-06 12:28:40 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14058 13885 0 44 122 7

Copy link

github-actions bot commented May 6, 2024

2024-05-06 10:16:49 UTC Pre-commit check for 8533d2d has started.
2024-05-06 10:16:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-06 10:38:10 UTC Build successful.
2024-05-06 10:40:01 UTC Tests are running...
🔴 2024-05-06 12:39:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72701 59594 0 5 13091 11

@igormunkin igormunkin marked this pull request as ready for review May 6, 2024 11:00
@igormunkin igormunkin requested a review from a team as a code owner May 6, 2024 11:00
@igormunkin igormunkin merged commit 0a0e28e into ydb-platform:main May 6, 2024
3 of 5 checks passed
@igormunkin igormunkin deleted the imun/enhance-diagnostic branch May 13, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants