Precompute all replicated connections if one already is #7067

ssmike · 2024-07-24T18:42:13Z

Changelog category

Bugfix

github-actions · 2024-07-24T18:45:55Z

⚪ 2024-07-24 18:45:54 UTC Pre-commit check for 991bcb2 has started.
⚪ 2024-07-24 18:48:43 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 19:10:15 UTC Build successful.

github-actions · 2024-07-24T18:46:10Z

⚪ 2024-07-24 18:46:10 UTC Pre-commit check for 991bcb2 has started.
⚪ 2024-07-24 18:48:54 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 20:26:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13774	12344	0	87	1325	18

⚪ 2024-07-24 20:28:48 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 20:36:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
98 (only retried tests)	3	0	87	0	8

⚪ 2024-07-24 20:38:34 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 20:46:29 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
96 (only retried tests)	1	0	87	0	8

🟢 2024-07-24 20:47:57 UTC Build successful.
🟡 2024-07-24 20:48:51 UTC ydbd size 8.1 GiB changed* by +833.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `5f5cf4c`	merge: `991bcb2`	diff	diff %
ydbd size	8 659 058 744 Bytes	8 659 912 224 Bytes	+833.5 KiB	+0.010%
ydbd stripped size	471 301 248 Bytes	471 331 552 Bytes	+29.6 KiB	+0.006%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-24T18:46:11Z

⚪ 2024-07-24 18:46:11 UTC Pre-commit check for 991bcb2 has started.
⚪ 2024-07-24 18:49:07 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-24 21:09:40 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9646	9028	0	114	329	175

🟢 2024-07-24 21:11:21 UTC Build successful.
🟡 2024-07-24 21:12:15 UTC ydbd size 5.2 GiB changed* by +799.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `5f5cf4c`	merge: `991bcb2`	diff	diff %
ydbd size	5 559 630 696 Bytes	5 560 449 520 Bytes	+799.6 KiB	+0.015%
ydbd stripped size	1 197 553 744 Bytes	1 197 678 544 Bytes	+121.9 KiB	+0.010%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-25T12:47:25Z

⚪ 2024-07-25 12:47:25 UTC Pre-commit check for b80d973 has started.
⚪ 2024-07-25 12:50:33 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-25 12:55:12 UTC Build successful.

github-actions · 2024-07-25T12:56:01Z

⚪ 2024-07-25 12:56:01 UTC Pre-commit check for b80d973 has started.
⚪ 2024-07-25 12:58:55 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 14:26:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13771	12429	0	4	1325	13

⚪ 2024-07-25 14:28:15 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 14:35:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16 (only retried tests)	3	0	3	0	10

⚪ 2024-07-25 14:37:05 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-25 14:44:36 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14 (only retried tests)	2	0	3	0	9

🟢 2024-07-25 14:45:47 UTC Build successful.
🟡 2024-07-25 14:46:25 UTC ydbd size 8.1 GiB changed* by +816.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `20355c6`	merge: `b80d973`	diff	diff %
ydbd size	8 665 329 744 Bytes	8 666 165 320 Bytes	+816.0 KiB	+0.010%
ydbd stripped size	471 462 464 Bytes	471 489 408 Bytes	+26.3 KiB	+0.006%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-25T13:07:26Z

⚪ 2024-07-25 13:07:26 UTC Pre-commit check for b80d973 has started.
⚪ 2024-07-25 13:10:40 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-25 15:20:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9643	9053	0	89	331	170

🟢 2024-07-25 15:21:45 UTC Build successful.
🟡 2024-07-25 15:22:42 UTC ydbd size 5.2 GiB changed* by +733.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `20355c6`	merge: `b80d973`	diff	diff %
ydbd size	5 563 235 720 Bytes	5 563 986 312 Bytes	+733.0 KiB	+0.013%
ydbd stripped size	1 198 030 960 Bytes	1 198 139 184 Bytes	+105.7 KiB	+0.009%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-28T12:53:03Z

⚪ 2024-07-28 12:53:03 UTC Pre-commit check for 179a4d5 has started.
⚪ 2024-07-28 12:55:58 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-28 14:56:33 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9639	9062	0	79	324	174

🟢 2024-07-28 14:57:30 UTC Build successful.
🟡 2024-07-28 14:58:20 UTC ydbd size 5.2 GiB changed* by +630.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ae7146c`	merge: `179a4d5`	diff	diff %
ydbd size	5 568 957 240 Bytes	5 569 603 144 Bytes	+630.8 KiB	+0.012%
ydbd stripped size	1 198 908 880 Bytes	1 199 005 904 Bytes	+94.8 KiB	+0.008%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-28T12:54:28Z

⚪ 2024-07-28 12:54:28 UTC Pre-commit check for 179a4d5 has started.
⚪ 2024-07-28 12:57:18 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-28 14:29:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13771	12425	0	5	1326	15

⚪ 2024-07-28 14:30:30 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-28 14:38:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19 (only retried tests)	9	0	2	0	8

⚪ 2024-07-28 14:39:23 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-28 14:47:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11 (only retried tests)	1	0	2	0	8

🟢 2024-07-28 14:48:29 UTC Build successful.
🟡 2024-07-28 14:49:19 UTC ydbd size 8.1 GiB changed* by +837.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ae7146c`	merge: `179a4d5`	diff	diff %
ydbd size	8 674 427 424 Bytes	8 675 284 704 Bytes	+837.2 KiB	+0.010%
ydbd stripped size	471 778 752 Bytes	471 805 824 Bytes	+26.4 KiB	+0.006%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-28T12:55:26Z

⚪ 2024-07-28 12:55:25 UTC Pre-commit check for 179a4d5 has started.
⚪ 2024-07-28 12:58:22 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-28 13:04:26 UTC Build successful.

github-actions · 2024-07-28T15:04:00Z

⚪ 2024-07-28 15:03:59 UTC Pre-commit check for 59341f3 has started.
⚪ 2024-07-28 15:06:54 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-28 15:11:40 UTC Build successful.

github-actions · 2024-07-28T15:04:21Z

⚪ 2024-07-28 15:04:21 UTC Pre-commit check for 59341f3 has started.
⚪ 2024-07-28 15:07:16 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-28 17:16:00 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9628	9046	0	85	325	172

🟢 2024-07-28 17:16:56 UTC Build successful.
🟡 2024-07-28 17:19:53 UTC ydbd size 5.2 GiB changed* by +618.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `4743435`	merge: `59341f3`	diff	diff %
ydbd size	5 568 970 360 Bytes	5 569 603 144 Bytes	+618.0 KiB	+0.011%
ydbd stripped size	1 198 914 000 Bytes	1 199 005 904 Bytes	+89.8 KiB	+0.008%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-28T15:04:34Z

⚪ 2024-07-28 15:04:34 UTC Pre-commit check for 59341f3 has started.
⚪ 2024-07-28 15:07:23 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-28 16:44:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13766	12427	0	3	1325	11

⚪ 2024-07-28 16:45:41 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-28 16:53:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12 (only retried tests)	3	0	1	0	8

⚪ 2024-07-28 16:54:33 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-28 17:02:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10 (only retried tests)	1	0	1	0	8

🟢 2024-07-28 17:03:11 UTC Build successful.
🟡 2024-07-28 17:03:36 UTC ydbd size 8.1 GiB changed* by +828.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `4743435`	merge: `59341f3`	diff	diff %
ydbd size	8 674 436 056 Bytes	8 675 284 704 Bytes	+828.8 KiB	+0.010%
ydbd stripped size	471 779 008 Bytes	471 805 824 Bytes	+26.2 KiB	+0.006%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

…db-platform#7067)

ssmike added 3 commits July 23, 2024 22:45

add double read

15b3af9

add params

80c6a49

Remove reads duplication

bb31075

github-actions bot added the bugfix label Jul 24, 2024

ssmike changed the title ~~Avoid stages duplication in transactions builder~~ Avoid stages duplication in transaction builder Jul 24, 2024

github-actions bot added bugfix and removed bugfix labels Jul 24, 2024

fix

e9a91df

move logic to finalizing transformer

93dee2f

ssmike changed the title ~~Avoid stages duplication in transaction builder~~ Precompute all replicated connections if one is already precomputed Jul 28, 2024

github-actions bot added bugfix and removed bugfix labels Jul 28, 2024

fix test

a4d0017

ssmike enabled auto-merge (squash) July 29, 2024 13:53

ssmike changed the title ~~Precompute all replicated connections if one is already precomputed~~ Precompute all replicated connections if one already is Jul 29, 2024

github-actions bot added bugfix and removed bugfix labels Jul 29, 2024

ssmike requested a review from spuchin July 30, 2024 11:51

spuchin approved these changes Jul 31, 2024

View reviewed changes

ssmike merged commit 439d5b8 into ydb-platform:main Jul 31, 2024
9 of 13 checks passed

ssmike added a commit that referenced this pull request Jul 31, 2024

recanonize after #7067 (#7328)

adaecb0

ssmike deleted the double-read branch July 31, 2024 16:23

StekPerepolnen mentioned this pull request Aug 8, 2024

tenantinfo handler added DatabaseStorage #7554

Merged

ssmike added a commit to ssmike/ydb that referenced this pull request Sep 17, 2024

Precompute all replicated connections if one is already precomputed (y…

b98e94b

…db-platform#7067)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Precompute all replicated connections if one already is #7067

Precompute all replicated connections if one already is #7067

ssmike commented Jul 24, 2024

github-actions bot commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

Precompute all replicated connections if one already is #7067

Precompute all replicated connections if one already is #7067

Conversation

ssmike commented Jul 24, 2024

Changelog category

github-actions bot commented Jul 24, 2024 • edited Loading

github-actions bot commented Jul 24, 2024 • edited Loading

github-actions bot commented Jul 24, 2024 • edited Loading

github-actions bot commented Jul 25, 2024 • edited Loading

github-actions bot commented Jul 25, 2024 • edited Loading

github-actions bot commented Jul 25, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading