Skip to content

result_format: data parser & builder #8748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2024
Merged

result_format: data parser & builder #8748

merged 4 commits into from
Sep 5, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Sep 4, 2024

Changelog entry

...

Changelog category

  • New feature

Additional information

...

@vitstn vitstn requested a review from a team as a code owner September 4, 2024 14:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 14:49:04 UTC Pre-commit check linux-x86_64-release-clang14 for b4d51a1 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 14:49:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for b4d51a1 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 14:49:25 UTC Pre-commit check linux-x86_64-release-asan for b4d51a1 has started.

@vitstn vitstn added the area/yql YQL query language issues label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 14:57:13 UTC Pre-commit check linux-x86_64-release-clang14 for b755f34 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 14:59:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for b755f34 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 15:00:51 UTC Pre-commit check linux-x86_64-release-asan for b755f34 has started.

@vitstn vitstn requested review from nepal and igormunkin September 4, 2024 15:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 15:56:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6e5dbd8 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 15:59:35 UTC Pre-commit check linux-x86_64-release-clang14 for 6e5dbd8 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 16:03:13 UTC Pre-commit check linux-x86_64-release-asan for 6e5dbd8 has started.

@vitstn vitstn added the rebase-and-check Rebase PR with the current base branch and check label Sep 4, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 22:21:03 UTC Pre-commit check linux-x86_64-release-clang14 for 6a62304 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 22:22:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6a62304 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

⚪ 2024-09-04 22:23:09 UTC Pre-commit check linux-x86_64-release-asan for 6a62304 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 09:06:45 UTC Pre-commit check linux-x86_64-release-clang14 for 8fe045d has started.
⚪ 2024-09-05 09:09:41 UTC ya make is running...
🟢 2024-09-05 09:16:45 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 09:06:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8fe045d has started.
⚪ 2024-09-05 09:09:46 UTC ya make is running...
🟡 2024-09-05 10:21:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78187 64387 0 8 13764 28

⚪ 2024-09-05 10:29:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-05 10:40:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 37 0 3 0 20

⚪ 2024-09-05 10:40:54 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-05 10:51:50 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28 (only retried tests) 7 0 2 0 19

🟢 2024-09-05 10:51:57 UTC Build successful.
🟢 2024-09-05 10:52:36 UTC ydbd size 8.4 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 732bf12 merge: 8fe045d diff diff %
ydbd size 9 001 104 776 Bytes 9 001 108 840 Bytes +4.0 KiB +0.000%
ydbd stripped size 486 652 968 Bytes 486 657 064 Bytes +4.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 09:07:43 UTC Pre-commit check linux-x86_64-release-asan for 8fe045d has started.
⚪ 2024-09-05 09:10:43 UTC ya make is running...
🔴 2024-09-05 11:02:02 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15949 15819 0 51 46 33

🟢 2024-09-05 11:03:23 UTC Build successful.
🟢 2024-09-05 11:03:58 UTC ydbd size 5.6 GiB changed* by +608 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 732bf12 merge: 8fe045d diff diff %
ydbd size 6 019 637 112 Bytes 6 019 637 720 Bytes +608 Bytes +0.000%
ydbd stripped size 1 507 074 288 Bytes 1 507 074 608 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 15:02:51 UTC Pre-commit check linux-x86_64-release-clang14 for 9109cf3 has started.
⚪ 2024-09-05 15:06:12 UTC ya make is running...
🟢 2024-09-05 15:37:51 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 15:16:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9109cf3 has started.
⚪ 2024-09-05 15:20:33 UTC ya make is running...
🟡 2024-09-05 16:30:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78183 64402 0 8 13752 21

⚪ 2024-09-05 16:38:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-05 16:46:14 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39 (only retried tests) 21 0 0 0 18

🟢 2024-09-05 16:46:22 UTC Build successful.
🟢 2024-09-05 16:46:59 UTC ydbd size 8.4 GiB changed* by +32 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c1d76d8 merge: 9109cf3 diff diff %
ydbd size 8 999 780 888 Bytes 8 999 780 920 Bytes +32 Bytes +0.000%
ydbd stripped size 486 649 224 Bytes 486 649 288 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 15:21:48 UTC Pre-commit check linux-x86_64-release-asan for 9109cf3 has started.
⚪ 2024-09-05 15:25:56 UTC ya make is running...
🔴 2024-09-05 17:25:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15976 15827 0 55 62 32

🟢 2024-09-05 17:26:47 UTC Build successful.
🟢 2024-09-05 17:27:25 UTC ydbd size 5.6 GiB changed* by +624 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 90dd99a merge: 9109cf3 diff diff %
ydbd size 6 017 807 040 Bytes 6 017 807 664 Bytes +624 Bytes +0.000%
ydbd stripped size 1 507 089 200 Bytes 1 507 089 520 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn enabled auto-merge (squash) September 5, 2024 16:51
igormunkin
igormunkin approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the patch! LGTM.

@vitstn vitstn merged commit 85d1fd0 into ydb-platform:main Sep 5, 2024
10 of 12 checks passed
@vitstn vitstn deleted the result_format_data branch September 5, 2024 19:26
@niksaveliev niksaveliev mentioned this pull request Sep 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 10, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Sep 12, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igormunkin igormunkin igormunkin approved these changes

@nepal nepal Awaiting requested review from nepal

Assignees
No one assigned
Labels
area/yql YQL query language issues new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitstn @igormunkin