-
Notifications
You must be signed in to change notification settings - Fork 647
Conditionally compile the code that uses AWS to pass windows build #8966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally compile the code that uses AWS to pass windows build #8966
Conversation
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
@@ -1,5 +1,15 @@ | |||
LIBRARY(run) | |||
|
|||
IF (OS_WINDOWS) | |||
CFLAGS( | |||
-DKIKIMR_DISABLE_S3_OPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that KIKIMR_DISABLE_S3_OPS
flag would be inherited from ydb/apps/ydbd/ya.make
. However, this was not the case in my tests, so I included it here.
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
This commit (#8823) breaks:
This PR fixes the first problem (broken windows build). The second problem cannot be fixed in GitHub and must be fixed in the next import to arcadia/contrib PR. (The fix is ready.)