Skip to content

the TEvTxCalcPredicate message for the completed transaction (#8809) #9226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Alek5andr-Kotov
Copy link
Collaborator

Changelog entry

Moved the fixes from the main branch.

After restarting, the PQ tablet can re-send the message TEvTxCalcPredicate to the partition. Currently, the actor of the partition does not check the PlanStep messages. This is a mistake. Since if he has already completed this transaction before, the predicate will be calculated incorrectly. As a result, the transaction may be partially completed.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner September 13, 2024 13:24
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 13:30:03 UTC Pre-commit check for bde4dd5 has started.
2024-09-13 13:32:41 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-13 13:55:21 UTC Build successful.
2024-09-13 13:55:36 UTC Tests are running...
🔴 2024-09-13 15:50:45 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11165 11096 0 9 28 32

🟢 2024-09-13 15:51:18 UTC ydbd size 5.5 GiB changed* by +14.2 KiB, which is < 100.0 KiB vs stable-24-3-9-hotfix: OK

ydbd size dash stable-24-3-9-hotfix: bce4f3a merge: bde4dd5 diff diff %
ydbd size 5 934 894 304 Bytes 5 934 908 864 Bytes +14.2 KiB +0.000%
ydbd stripped size 1 487 932 832 Bytes 1 487 935 776 Bytes +2.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 6817342 into ydb-platform:stable-24-3-9-hotfix Sep 13, 2024
3 of 8 checks passed
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 13:34:21 UTC Pre-commit check for bde4dd5 has started.
2024-09-13 13:36:50 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-13 13:44:19 UTC Build successful.

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 13:50:30 UTC Pre-commit check for bde4dd5 has started.
2024-09-13 13:53:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-13 14:33:16 UTC Build successful.
2024-09-13 14:33:33 UTC Tests are running...
🔴 2024-09-13 15:56:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15474 14138 0 6 1299 31

🟢 2024-09-13 15:57:36 UTC ydbd size 8.2 GiB changed* by +21.2 KiB, which is < 100.0 KiB vs stable-24-3-9-hotfix: OK

ydbd size dash stable-24-3-9-hotfix: bce4f3a merge: bde4dd5 diff diff %
ydbd size 8 761 296 720 Bytes 8 761 318 472 Bytes +21.2 KiB +0.000%
ydbd stripped size 479 019 144 Bytes 479 020 488 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants