Skip to content

the TEvTxCalcPredicate message for the completed transaction #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Sep 5, 2024

Changelog entry

After restarting, the PQ tablet can re-send the message TEvTxCalcPredicate to the partition. Currently, the actor of the partition does not check the PlanStep messages. This is a mistake. Since if he has already completed this transaction before, the predicate will be calculated incorrectly. As a result, the transaction may be partially completed.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner September 5, 2024 13:54
@github-actions github-actions bot added the bugfix label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 16:04:23 UTC Pre-commit check linux-x86_64-release-asan for 05f6089 has started.
2024-09-05 16:08:12 UTC ya make is running...
🔴 2024-09-05 18:11:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11331 11204 0 56 39 32

🟢 2024-09-05 18:12:25 UTC Build successful.
🟢 2024-09-05 18:12:58 UTC ydbd size 5.6 GiB changed* by +14.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 90dd99a merge: 05f6089 diff diff %
ydbd size 6 017 807 040 Bytes 6 017 822 080 Bytes +14.7 KiB +0.000%
ydbd stripped size 1 507 089 200 Bytes 1 507 092 240 Bytes +3.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 16:06:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 05f6089 has started.
2024-09-05 16:10:41 UTC ya make is running...
🟡 2024-09-05 17:20:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15946 14482 0 63 1375 26

2024-09-05 17:22:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-05 17:32:00 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 87 0 0 0 18

🟢 2024-09-05 17:32:08 UTC Build successful.
🟢 2024-09-05 17:32:57 UTC ydbd size 8.4 GiB changed* by -88.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 90dd99a merge: 05f6089 diff diff %
ydbd size 8 999 780 888 Bytes 8 999 690 304 Bytes -88.5 KiB -0.001%
ydbd stripped size 486 649 224 Bytes 486 650 504 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 16:08:18 UTC Pre-commit check linux-x86_64-release-clang14 for 05f6089 has started.
2024-09-05 16:11:16 UTC ya make is running...
🟢 2024-09-05 16:32:44 UTC Build successful.

@Alek5andr-Kotov Alek5andr-Kotov changed the title WIP: the TEvTxCalcPredicate message for the completed transaction the TEvTxCalcPredicate message for the completed transaction Sep 5, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Sep 5, 2024
@Alek5andr-Kotov Alek5andr-Kotov merged commit 79a6b7a into ydb-platform:main Sep 5, 2024
13 of 15 checks passed
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Sep 13, 2024
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants