Make teamId in cluster name optional #2001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
CyberDem0n,
jopadi and
idanovinda
as code owners
Jan-M
reviewed
Aug 17, 2022
| @@ -53,8 +53,7 @@ Those parameters are grouped under the `metadata` top-level key. | |||
| These parameters are grouped directly under the `spec` key in the manifest. | |||
|
|
|||
| * **teamId** | |||
| name of the team the cluster belongs to. Changing it after the cluster | |||
| creation is not supported. Required field. | |||
| name of the team the cluster belongs to. Required field. | |||
There was a problem hiding this comment.
Should inform about settings and implications. it may still be impossible.
There was a problem hiding this comment.
it's now possible to change it later. When enable_team_id_clustername_prefix is enabled you will only get an error on sync that cluster name does not match the { TEAM-ID }-{... format with status being set to inavlid.
Jan-M
reviewed
Aug 17, 2022
Jan-M
reviewed
Aug 17, 2022
| tmp2.Status = PostgresStatus{PostgresClusterStatus: ClusterStatusInvalid} | ||
| } else if err := validateCloneClusterDescription(tmp2.Spec.Clone); err != nil { | ||
|
|
||
| if err := validateCloneClusterDescription(tmp2.Spec.Clone); err != nil { |
There was a problem hiding this comment.
how is this related to clone? maybe better function name? or is this indeed about cloning?
There was a problem hiding this comment.
yes, this is a validation of the clone section. Existed also before.
|
👍 |
1 similar comment
|
👍 |
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teams of cluster change. Although the name of the cluster is immutable, it would still be helpful to change teamId field without the need to create a PostgresTeam resource.
On start up the operator calls
add_clusterfor all Postgresql resource it finds. When the newenable_team_id_clustername_prefixis enabled and cluster name does not start with team ID,add_clusterwill return an error message and the cluster is not added to the operator's internal cluster list.The Postgresql resource itself still gets created via K8s API. We have no controller in between to block this. Because the resource is there we can patch it's
PostgresClusterStatusfield in status subresource toinvalid. Each sync on the cluster will try to call add_cluster again because it does not exist in the operator#s internal list. When the option is turned off and operator is restarted, the cluster is synced like very other cluster.This PR keeps
teamIdas anrequiredfield of the cluster manifest (because we want to keep cluster ownership from teams) and it deprecates the cluster's internalClusterNamefield which used to store the cluster name without theteamIdprefix. We did not use theClusterNameanywhere else.