use old LB DNS format when teamId prefix is disabled #2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
CyberDem0n,
jopadi and
idanovinda
as code owners
|
👍 |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2001 merged we dropped the teamId prefix constraint for cluster names and deprecated the
ClusterNamefield of thePostgresqltype assuming it was not used somewhere else. Turns out, it is used for LoadBalancer service's external DNS name and ClusterStatus API.This PR will set this field again when clusters are added to the operator's internal cluster list.
If we would continue to use the Spec.ClusterName for the LB DNS names they would break when disabling the team Id constraint. Therefore, we should continue to use old format when the cluster name starts with the team ID. external-dns supports multiple names per annotation, separated by comma.