nrfx_glue: Replace IS_ENABLED() with defined(), to not depend on util.h #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to commit f5b5469. It removes the dependency on <sys/util.h> (that brings the definition of the IS_ENABLED macro) that was previously included via <kernel.h>, because in some scenarios this file (nrfx_glue.h) may be processed before <kernel.h> and hence <sys/util.h> is actually included. Signed-off-by: Andrzej Głąbek <[email protected]>
SebastianBoe
approved these changes
Sep 24, 2019
|
@anangl pls, notify when the zephyr PR with this HEAD has completed the CI |
ioannisg
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to commit f5b5469.
It removes the dependency on <sys/util.h> (that brings the definition
of the IS_ENABLED macro) that was previously included via <kernel.h>,
because in some scenarios this file (nrfx_glue.h) may be processed
before <kernel.h> and hence <sys/util.h> is actually included.
Signed-off-by: Andrzej Głąbek [email protected]