nordic: Clean up nrfx inclusions #19304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anangl
added
Enhancement
anangl
requested review from
SebastianBoe,
ioannisg,
cvinayak,
carlescufi and
pizi-nordic
anangl
requested review from
galak,
jukkar,
lemrey,
MaureenHelm,
nashif,
tbursztyka and
thoh-ot
as code owners
zephyrbot
added
area: Sensors
anangl
removed request for
nashif,
jukkar,
tbursztyka,
MaureenHelm,
galak and
thoh-ot
anangl
added
Blocked
|
Removed no longer existing directory |
ioannisg
approved these changes
Sep 23, 2019
SebastianBoe
approved these changes
Sep 23, 2019
ioannisg
reviewed
Sep 23, 2019
anangl
force-pushed
the
clean_up_nrfx_inclusions
branch
from
e15cfc3 to
d2f5217
Compare
|
Updated |
anangl
removed
Blocked
pizi-nordic
approved these changes
Sep 23, 2019
Header files of nrfx HALs are not supposed to be included directly but only with their names prepended with the hal/ directory (so that an inclusion of an nrfx HAL header clearly differs from an inclusion of an nrfx driver header). Signed-off-by: Andrzej Głąbek <[email protected]>
anangl
force-pushed
the
clean_up_nrfx_inclusions
branch
from
d2f5217 to
c1abc59
Compare
Rebased. |
anangl
force-pushed
the
clean_up_nrfx_inclusions
branch
from
c1abc59 to
c5a3716
Compare
anangl
added
Blocked
|
Blocked by zephyrproject-rtos/hal_nordic#7 which contains the fix for failing builds. |
This change is done so that there is no need to additionaly include <nrfx.h> before <soc/nrfx_coredep.h> (what might be a bit surprising) and so that <nrfx_config.h> doesn't need to be include separately for nRF SoCs requiring a special mapping of peripheral accessing symbols. This commit removes also no longer needed inclusions and updates the hal_nordic module with required minor correction of nrfx_glue.h. Signed-off-by: Andrzej Głąbek <[email protected]>
This file contains redundant definitions of a bunch of nRF IRQ numbers (not all, however) that only generates confusion, as enumeration values provided by MDK can be used instead. Signed-off-by: Andrzej Głąbek <[email protected]>
anangl
force-pushed
the
clean_up_nrfx_inclusions
branch
from
c5a3716 to
eb3fcd5
Compare
anangl
removed
Blocked
|
Updated |
ioannisg
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of commits intended to clean up inclusions of nrfx files.
nordic: Use hal/ in all inclusions of nrfx HAL header files
Header files of nrfx HALs are not supposed to be included directly
but only with their names prepended with the hal/ directory (so that
an inclusion of an nrfx HAL header clearly differs from an inclusion
of an nrfx driver header).
soc: nordic: Include <nrfx.h> instead of <nrf.h> from <soc.h>
This change is done so that there is no need to additionaly include
<nrfx.h> before <soc/nrfx_coredep.h> (what might be a bit surprising)
and so that <nrfx_config.h> doesn't need to be include separately for
nRF SoCs requiring a special mapping of peripheral accessing symbols.
This commit removes also no longer needed inclusions and updates
the hal_nordic module with required minor correction of nrfx_glue.h.
soc: nordic: Get rid of nrf_common.h
This file contains redundant definitions of a bunch of nRF IRQ numbers
(not all, however) that only generates confusion, as enumeration values
provided by MDK can be used instead.
Requires zephyrproject-rtos/hal_nordic#5 to go in first.