Skip to content

mcux: hal_nxp: Include mipi_csi2rx driver #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ngphibang
Copy link
Contributor

This is to include the low level mipi csi-2 Rx driver which is needed for this PR

@decsny
Copy link
Member

decsny commented Mar 8, 2024

This is a bit of a nitpick but it's a bit unconventional to have the vendor name at the end of a kconfig name, can you change it to CONFIG_MCUX_MIPI_CSI2RX (mcux also signifies the use of the mcux hal)

And actually since its part of the video subsystem maybe it should even be CONFIG_VIDEO_MCUX_MIPI_CSI2RX since it is standard to namespace kconfigs with the subsystem they are a part of

@ngphibang
Copy link
Contributor Author

ngphibang commented Mar 8, 2024

@decsny Thanks. Yes, I think so, too. I hesitated so much about the naming. Frankly, I am a bit confused between "mcux" and "imx" (imx seems covers both mcu and mpu, etc). As this is also part of the zephyr PR , could we discuss there so that I could have more advices from others then I will change the naming all at once ?

Update cmake to include mipi_csi2rx driver from mcux-sdk repo

Signed-off-by: Phi Bang Nguyen <[email protected]>
@ngphibang ngphibang force-pushed the include_mipi_csi2rx_driver branch from 0740f01 to c6cfb6f Compare March 13, 2024 23:15
@ngphibang
Copy link
Contributor Author

@decsny I changed the config name.

@ngphibang
Copy link
Contributor Author

@decsny Could you approve and merge the PR ?
Thanks !

@decsny decsny merged commit db6806f into zephyrproject-rtos:master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants