Add support for camera on i.MX RT11XX #69810

ngphibang · 2024-03-05T15:00:28Z

This PR adds support to enable camera on i.MX RT11XX series. It adds

ov5640 camera driver
MIPI CSI-2 Rx driver
Modify CSI driver to support both RT11XX and RT10XX
Improve the video capture sample to display frames on LCD panel instead of just discarding them. For this to work, another PR should be merged first.

zephyrbot · 2024-03-07T22:34:39Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

ngphibang · 2024-03-08T14:04:17Z

Hi @danieldegrasse , @decsny , @DerekSnell, could you please advise on the naming of the MIPI CSI-2 Rx driver ?

Currently, I named it "mipi_csi2rx_nxp" because I remembered @DerekSnell has said that :

We should not use imx in the name. We reuse our IP everywhere across SOC families. So we should not include SOC family names in the drivers or bindings.

@decsny also proposed "CONFIG_VIDEO_MCUX_MIPI_CSI2RX". I think it is correct too. But frankly, I am a bit confused between "mcux" and "imx" (imx seems covers both mcu and mpu ?). So, I hesitated too much.

Is it ok for you if we name them as below ?

CONFIG_VIDEO_MCUX_MIPI_CSI2RX
video_mcux_mipi_csi2rx.c
nxp,mipi-csi2rx.yaml
Kconfig.mcux_mipi_csi2rx

Thanks

decsny · 2024-03-08T14:09:20Z

But frankly, I am a bit confused between "mcux" and "imx" (imx seems covers both mcu and mpu ?).

MCUX refers to the MCUX-SDK. Which can theoretically have any kind of device in it, it's just a software ecosystem. IMX refers to the IMX MPU family. For the IMX MCU (RT family), they are called by IMXRT. (see soc/nxp folder).

Update documents and tests to support the i.MX RT1170 EVK, the video test pattern generator and the new camera shields. Signed-off-by: Phi Bang Nguyen <[email protected]>

Add entry for ov5640 and add mimxrt1170_evk to the test platforms Signed-off-by: Phi Bang Nguyen <[email protected]>

Enable video feature on cm7 evk and evkb which are tested with ov5640 camera. Signed-off-by: Phi Bang Nguyen <[email protected]>

ngphibang · 2024-04-15T16:49:56Z

@danieldegrasse I updated the PR which addressed all of your comments in my possibility (for some comments that I cannot make the changes, I left my arguments).

@loicpoulain , @danieldegrasse , @dleach02 : Really need your helps to make this PR moving forward as it has been here for quite a while.

Thanks !

loicpoulain · 2024-04-24T07:43:57Z

@ngphibang could you split this PR in different logical PRs (like one for misc fixes, one for new camera driver, etc...), it will be easier for you to have them reviewed and integrated.

ngphibang · 2024-04-24T08:39:22Z

@loicpoulain Okay, I will do it. But the problem is the next PR will depend on all previous PRs and Zephyr requires that each commit / PR is bisectable and buildable.

Would you mind if I include all the commits of the previous PRs into another PR ? For example :

PR 1
PR 2 = its commits + commits of PR 1
PR 3 = its commits + all PR2

ngphibang · 2024-04-24T09:59:58Z

@loicpoulain The first 3 splitted PRs which are independent each others are pushed.
Waiting for your reviews and integration before continuing to push the next ones which depend on these.

mmahadevan108 · 2024-05-14T21:17:08Z

drivers/video/video_mcux_csi.c


 	if (!bpp || ep != VIDEO_EP_OUT) {
 		return -EINVAL;
 	}

-	data->pixelformat = fmt->pixelformat;


This can be deleted from video_mcux_csi_data

Also, this commit can be squashed with the previous commit.

Yes, it is addressed and merged.

mmahadevan108 · 2024-05-14T21:23:59Z

dts/arm/nxp/nxp_rt11xx.dtsi

@@ -1230,3 +1230,7 @@
 	 */
 	status = "disabled";
 };
+
+zephyr_cam_i2c: &lpi2c6 {};


This seems board specific and probably belongs in the board overlay file.

yes, it is pointed out by Daniel and I addressed it in the split PR.

mmahadevan108 · 2024-05-14T21:25:51Z

boards/nxp/mimxrt1064_evk/mimxrt1064_evk.dts

-		csi_ep_in: endpoint {
-			remote-endpoint = <&mt9m114_ep_out>;
-		};
-	};


Do we need to add the labels related to the new shield you have created for 1064?

ngphibang · 2024-05-14T21:48:40Z

@mmahadevan108 : Thank you for your reviews ! But this PR is split into smaller one as requested by Loic. Could you review them instead ? I don't know if we can add a label "do not review" or "stale" or something like that on this PR ?

mmahadevan108 · 2024-05-14T21:54:21Z

samples/subsys/video/capture/README.rst

@@ -7,9 +7,8 @@
 Description
 ***********


Has this been tested in 1064_evk after the changes to the sample? Do we need a boards overlay file for 1064_evk?

yes, it's tested. The board overlay for 1064 evk is in the same PR.

danieldegrasse · 2024-05-14T22:02:16Z

@ngphibang is this PR still needed? My understanding was that all the components of this PR had been split into smaller PRs. If we don't need this one open, let's go ahead and close it out to avoid additional review noise

ngphibang · 2024-05-14T22:05:15Z

I thought that we should keep it as a reference and just close it when all the split PRs merged.
I close it now, sorry.

ngphibang · 2024-05-14T22:06:01Z

Close to avoid additional review noise

danieldegrasse · 2024-05-14T22:06:59Z

I thought that we should keep it as a reference and just close it when all the split PRs merged.
I close it now, sorry.

No worries- just don't want anyone reviewing the enablement to get confused by this PR :)

ngphibang requested review from mmahadevan108 and dleach02 as code owners March 5, 2024 15:00

zephyrbot added platform: NXP NXP area: Shields Shields (add-on boards) area: Devicetree Binding PR modifies or adds a Device Tree binding area: Samples Samples platform: NXP Drivers NXP Semiconductors, drivers area: Video Video subsystem labels Mar 5, 2024

zephyrbot requested review from avisconti, danieldegrasse, dbaluta, decsny, DerekSnell, EmilioCBen, erwango, jfischer-no, kartben, loicpoulain, manuargue, nashif and yvanderv March 5, 2024 15:01

zephyrbot assigned dleach02 Mar 5, 2024

This was referenced Mar 5, 2024

Improve video sw generator #69817

Merged

mcux: hal_nxp: Include mipi_csi2rx driver zephyrproject-rtos/hal_nxp#348

Merged

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Mar 7, 2024

ngphibang added 3 commits April 15, 2024 18:28

samples: video: capture: Update documents and tests

83094db

Update documents and tests to support the i.MX RT1170 EVK, the video test pattern generator and the new camera shields. Signed-off-by: Phi Bang Nguyen <[email protected]>

tests: drivers: build_all: video: Add entry for ov5640

41f5802

Add entry for ov5640 and add mimxrt1170_evk to the test platforms Signed-off-by: Phi Bang Nguyen <[email protected]>

boards: nxp: mimxrt1170_evk: Enable video feature

1325e3e

Enable video feature on cm7 evk and evkb which are tested with ov5640 camera. Signed-off-by: Phi Bang Nguyen <[email protected]>

zephyrbot removed manifest manifest-hal_nxp labels Apr 15, 2024

This was referenced Apr 24, 2024

Add ov5640 camera driver #71854

Merged

Add mipi csi2 rx driver #71859

Merged

Some misc fixes on CSI driver #71860

Merged

mmahadevan108 reviewed May 14, 2024

View reviewed changes

DerekSnell removed their request for review May 14, 2024 21:51

mmahadevan108 reviewed May 14, 2024

View reviewed changes

ngphibang closed this May 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for camera on i.MX RT11XX #69810

Add support for camera on i.MX RT11XX #69810

ngphibang commented Mar 5, 2024

zephyrbot commented Mar 7, 2024 •

edited

Loading

ngphibang commented Mar 8, 2024 •

edited

Loading

decsny commented Mar 8, 2024

ngphibang commented Apr 15, 2024 •

edited

Loading

loicpoulain commented Apr 24, 2024

ngphibang commented Apr 24, 2024

ngphibang commented Apr 24, 2024

mmahadevan108 May 14, 2024

mmahadevan108 May 14, 2024

ngphibang May 14, 2024

mmahadevan108 May 14, 2024

ngphibang May 14, 2024

mmahadevan108 May 14, 2024

ngphibang commented May 14, 2024

mmahadevan108 May 14, 2024

ngphibang May 14, 2024

danieldegrasse commented May 14, 2024

ngphibang commented May 14, 2024

ngphibang commented May 14, 2024

danieldegrasse commented May 14, 2024

Add support for camera on i.MX RT11XX #69810

Add support for camera on i.MX RT11XX #69810

Conversation

ngphibang commented Mar 5, 2024

zephyrbot commented Mar 7, 2024 • edited Loading

ngphibang commented Mar 8, 2024 • edited Loading

decsny commented Mar 8, 2024

ngphibang commented Apr 15, 2024 • edited Loading

loicpoulain commented Apr 24, 2024

ngphibang commented Apr 24, 2024

ngphibang commented Apr 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngphibang commented May 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danieldegrasse commented May 14, 2024

ngphibang commented May 14, 2024

ngphibang commented May 14, 2024

danieldegrasse commented May 14, 2024

zephyrbot commented Mar 7, 2024 •

edited

Loading

ngphibang commented Mar 8, 2024 •

edited

Loading

ngphibang commented Apr 15, 2024 •

edited

Loading