Skip to content

Failed test: kernel.sched.slice_reset and kernel.sched.slice_scheduling (tests/kernel/sched/schedule_api/kernel.sched) on nrf51/nrf52 #8896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zephyrbot opened this issue Jul 12, 2018 · 1 comment · Fixed by #9137
Closed

Failed test: kernel.sched.slice_reset and kernel.sched.slice_scheduling (tests/kernel/sched/schedule_api/kernel.sched) on nrf51/nrf52 #8896

zephyrbot opened this issue Jul 12, 2018 · 1 comment · Fixed by #9137
Assignees
@pizi-nordic
Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Milestone
v1.13.0

Comments

@zephyrbot
Copy link
Collaborator 

***** delaying boot 1000ms (per build configuration) *****
 ***** Booting Zephyr OS 1.12.99 (delayed boot 1000ms) *****
 Running test suite threads_scheduling
 ===================================================================
 starting test - test_priority_cooperative
 PASS - test_priority_cooperative
 ===================================================================
 starting test - test_priority_preemptible
 PASS - test_priority_preemptible
 ===================================================================
 starting test - test_yield_cooperative
 PASS - test_yield_cooperative
 ===================================================================
 starting test - test_sleep_cooperative
 PASS - test_sleep_cooperative
 ===================================================================
 starting test - test_sleep_wakeup_preemptible
 PASS - test_sleep_wakeup_preemptible
 ===================================================================
 starting test - test_pending_thread_wakeup
 PASS - test_pending_thread_wakeup
 ===================================================================
 starting test - test_time_slicing_preemptible
 PASS - test_time_slicing_preemptible
 ===================================================================
 starting test - test_time_slicing_disable_preemptible
 PASS - test_time_slicing_disable_preemptible
 ===================================================================
 starting test - test_lock_preemptible
 PASS - test_lock_preemptible
 ===================================================================
 starting test - test_unlock_preemptible
 PASS - test_unlock_preemptible
 ===================================================================
 starting test - test_sched_is_preempt_thread
 PASS - test_sched_is_preempt_thread
 ===================================================================
 starting test - test_slice_reset

     Assertion failed at zephyr.git/tests/kernel/sched/schedule_api/src/test_sched_timeslice_reset.c:39: thread_tslice: t <= expected_slice[thread_idx] is false

 FAIL - test_slice_reset
 ===================================================================
 starting test - test_slice_scheduling
 A
     Assertion failed at zephyr.git/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:48: thread_tslice: ((tdelta <= SLICE_SIZE) && ((int)p1 == thread_idx)) is false

 B
     Assertion failed at zephyr.git/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:48: thread_tslice: ((tdelta <= SLICE_SIZE) && ((int)p1 == thread_idx)) is false



     Assertion failed at zephyr.git/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:48: thread_tslice: ((tdelta <= SLICE_SIZE) && ((int)p1 == thread_idx)) is false

 FAIL - test_slice_scheduling
 ===================================================================
 starting test - test_priority_scheduling
 PASS - test_priority_scheduling
 ===================================================================
 ===================================================================
 RunID: ci-180710-1801-1919:h6ps
 PROJECT EXECUTION FAILED
@zephyrbot zephyrbot added this to the v1.13.0 milestone Jul 12, 2018
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug labels Jul 12, 2018
@pswarnak
Copy link
Contributor

pswarnak commented Jul 17, 2018 •
edited
Loading

This test also failed on nrf52_pca10040 and nrf52840_pca10056 with the same error signature.

@pswarnak pswarnak changed the title Failed test: kernel.sched.slice_reset (tests/kernel/sched/schedule_api/kernel.sched) on nrf51 Failed test: kernel.sched.slice_reset and kernel.sched.slice_scheduling (tests/kernel/sched/schedule_api/kernel.sched) on nrf51/nrf52 Jul 17, 2018
@pizi-nordic pizi-nordic mentioned this issue Jul 25, 2018
Merged
@pizi-nordic pizi-nordic mentioned this issue Jul 26, 2018
Merged
pizi-nordic added a commit to pizi-nordic/zephyr that referenced this issue Jul 26, 2018
@pizi-nordic
kernel: sched: Use ticks as time unit in time slicing.
37e105d 
The time slicing settings was kept in milliseconds while all related
operations was based on ticks. Continuous back and forth conversion
between ticks and milliseconds introduced an accumulating error due
to rounding in _ms_to_ticks() and __ticks_to_ms(). As result
configured time slice duration was not achieved.

This commit removes excessive ticks <-> ms conversion by using ticks
as time unit for all operations related to time slicing.

Also, it fixes zephyrproject-rtos#8896 as well as zephyrproject-rtos#8897.

Signed-off-by: Piotr Zięcik <[email protected]>
pizi-nordic added a commit to pizi-nordic/zephyr that referenced this issue Aug 2, 2018
@pizi-nordic
kernel: sched: Use ticks as time unit in time slicing.
8070e15 
The time slicing settings was kept in milliseconds while all related
operations was based on ticks. Continuous back and forth conversion
between ticks and milliseconds introduced an accumulating error due
to rounding in _ms_to_ticks() and __ticks_to_ms(). As result
configured time slice duration was not achieved.

This commit removes excessive ticks <-> ms conversion by using ticks
as time unit for all operations related to time slicing.

Also, it fixes zephyrproject-rtos#8896 as well as zephyrproject-rtos#8897.

Signed-off-by: Piotr Zięcik <[email protected]>
@pswarnak pswarnak mentioned this issue Aug 8, 2018
Closed
nashif pushed a commit that referenced this issue Aug 13, 2018
@pizi-nordic @nashif
kernel: sched: Use ticks as time unit in time slicing.
4a39b9e 
The time slicing settings was kept in milliseconds while all related
operations was based on ticks. Continuous back and forth conversion
between ticks and milliseconds introduced an accumulating error due
to rounding in _ms_to_ticks() and __ticks_to_ms(). As result
configured time slice duration was not achieved.

This commit removes excessive ticks <-> ms conversion by using ticks
as time unit for all operations related to time slicing.

Also, it fixes #8896 as well as #8897.

Signed-off-by: Piotr Zięcik <[email protected]>
nashif pushed a commit that referenced this issue Aug 14, 2018
@pizi-nordic @nashif
kernel: sched: Use ticks as time unit in time slicing.
2a26576 
The time slicing settings was kept in milliseconds while all related
operations was based on ticks. Continuous back and forth conversion
between ticks and milliseconds introduced an accumulating error due
to rounding in _ms_to_ticks() and __ticks_to_ms(). As result
configured time slice duration was not achieved.

This commit removes excessive ticks <-> ms conversion by using ticks
as time unit for all operations related to time slicing.

Also, it fixes #8896 as well as #8897.

Signed-off-by: Piotr Zięcik <[email protected]>
@pizi-nordic pizi-nordic mentioned this issue Sep 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pizi-nordic pizi-nordic

Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

kernel: sched: Use ticks as time unit in time slicing. pizi-nordic/zephyr
3 participants
@pizi-nordic @zephyrbot @pswarnak