Skip to content

Failed test: kernel.tickless.tickless_slice on nrf51/nrf52 #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zephyrbot opened this issue Jul 12, 2018 · 1 comment
Closed

Failed test: kernel.tickless.tickless_slice on nrf51/nrf52 #8897

zephyrbot opened this issue Jul 12, 2018 · 1 comment
Assignees
@pizi-nordic
Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Milestone
v1.13.0

Comments

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jul 12, 2018 •
edited by pswarnak
Loading

Test tests/kernel/tickless/tickless_concept/kernel.tickless failing on nrf51/nrf52

***** delaying boot 1000ms (per build configuration) *****
 ***** Booting Zephyr OS 1.12.99 (delayed boot 1000ms) *****
 Running test suite tickless_concept
 ===================================================================
 starting test - test_tickless_sysclock
 time 1027, 1237
 time 1247, 1446
 PASS - test_tickless_sysclock
 ===================================================================
 starting test - test_tickless_slice
 elapsed slice 110
 elapsed slice 120

     Assertion failed at zephyr.git/tests/kernel/tickless/tickless_concept/src/main.c:53: thread_tslice: t <= (SLICE_SIZE + MSEC_PER_TICK) is false

 elapsed slice 20

     Assertion failed at zephyr.git/tests/kernel/tickless/tickless_concept/src/main.c:51: thread_tslice: t >= SLICE_SIZE is false

 elapsed slice 20

     Assertion failed at zephyr.git/tests/kernel/tickless/tickless_concept/src/main.c:51: thread_tslice: t >= SLICE_SIZE is false

 FAIL - test_tickless_slice
 ===================================================================
 ===================================================================
 RunID: ci-180710-1801-1919:9cre
 PROJECT EXECUTION FAILED
@zephyrbot zephyrbot added this to the v1.13.0 milestone Jul 12, 2018
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug labels Jul 12, 2018
@pizi-nordic pizi-nordic mentioned this issue Jul 17, 2018
Closed
@pswarnak pswarnak changed the title Failed test: kernel.tickless.tickless_slice on nrf51 Failed test: kernel.tickless.tickless_slice on nrf51/nrf52 Jul 18, 2018
pizi-nordic added a commit to pizi-nordic/zephyr that referenced this issue Jul 26, 2018
@pizi-nordic
kernel: sched: Use ticks as time unit in time slicing.
37e105d 
The time slicing settings was kept in milliseconds while all related
operations was based on ticks. Continuous back and forth conversion
between ticks and milliseconds introduced an accumulating error due
to rounding in _ms_to_ticks() and __ticks_to_ms(). As result
configured time slice duration was not achieved.

This commit removes excessive ticks <-> ms conversion by using ticks
as time unit for all operations related to time slicing.

Also, it fixes zephyrproject-rtos#8896 as well as zephyrproject-rtos#8897.

Signed-off-by: Piotr Zięcik <[email protected]>
@pizi-nordic pizi-nordic mentioned this issue Jul 26, 2018
Merged
pizi-nordic added a commit to pizi-nordic/zephyr that referenced this issue Aug 2, 2018
@pizi-nordic
kernel: sched: Use ticks as time unit in time slicing.
8070e15 
The time slicing settings was kept in milliseconds while all related
operations was based on ticks. Continuous back and forth conversion
between ticks and milliseconds introduced an accumulating error due
to rounding in _ms_to_ticks() and __ticks_to_ms(). As result
configured time slice duration was not achieved.

This commit removes excessive ticks <-> ms conversion by using ticks
as time unit for all operations related to time slicing.

Also, it fixes zephyrproject-rtos#8896 as well as zephyrproject-rtos#8897.

Signed-off-by: Piotr Zięcik <[email protected]>
nashif pushed a commit that referenced this issue Aug 13, 2018
@pizi-nordic @nashif
kernel: sched: Use ticks as time unit in time slicing.
4a39b9e 
The time slicing settings was kept in milliseconds while all related
operations was based on ticks. Continuous back and forth conversion
between ticks and milliseconds introduced an accumulating error due
to rounding in _ms_to_ticks() and __ticks_to_ms(). As result
configured time slice duration was not achieved.

This commit removes excessive ticks <-> ms conversion by using ticks
as time unit for all operations related to time slicing.

Also, it fixes #8896 as well as #8897.

Signed-off-by: Piotr Zięcik <[email protected]>
@pizi-nordic
Copy link
Collaborator

Fixed by #9137

nashif pushed a commit that referenced this issue Aug 14, 2018
@pizi-nordic @nashif
kernel: sched: Use ticks as time unit in time slicing.
2a26576 
The time slicing settings was kept in milliseconds while all related
operations was based on ticks. Continuous back and forth conversion
between ticks and milliseconds introduced an accumulating error due
to rounding in _ms_to_ticks() and __ticks_to_ms(). As result
configured time slice duration was not achieved.

This commit removes excessive ticks <-> ms conversion by using ticks
as time unit for all operations related to time slicing.

Also, it fixes #8896 as well as #8897.

Signed-off-by: Piotr Zięcik <[email protected]>
@pizi-nordic pizi-nordic mentioned this issue Sep 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pizi-nordic pizi-nordic

Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v1.13.0
Development

No branches or pull requests
2 participants
@pizi-nordic @zephyrbot