Skip to content

arch: arm: userspace: minor refactor in z_arch_is_user_context #17189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ioannisg
Copy link
Member

@ioannisg ioannisg commented Jul 1, 2019

Refactor z_arch_is_user_context() for ARM, so it uses
the CMSIS CONTROL_nPRIV_Msk instead of the hard-coded 0x1.
Fix also some typos.

Signed-off-by: Ioannis Glaropoulos [email protected]

Trivial. No behavioral change.

@ioannisg ioannisg added Enhancement Changes/Updates/Additions to existing features area: ARM ARM (32-bit) Architecture Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Jul 1, 2019
@zephyrbot zephyrbot added the area: API Changes to public APIs label Jul 1, 2019
@ioannisg
Copy link
Member Author

ioannisg commented Jul 1, 2019

Doesn't harm to backport it, but no real value, either.

@ioannisg
Copy link
Member Author

ioannisg commented Jul 1, 2019

The cyclic inclusions of the cmsis headers in ARM builds is a real challenge....

@ioannisg ioannisg added this to the v2.1.0 milestone Aug 12, 2019
@ioannisg ioannisg force-pushed the arch_arm_userspace_make_z_arch_is_user_context_use_CMSIS branch from d86dad3 to 913da46 Compare September 20, 2019 15:36
@ioannisg ioannisg force-pushed the arch_arm_userspace_make_z_arch_is_user_context_use_CMSIS branch from 913da46 to 5542cf4 Compare September 22, 2019 17:36
@ioannisg ioannisg removed the area: API Changes to public APIs label Sep 22, 2019
@zephyrbot zephyrbot added the area: API Changes to public APIs label Sep 22, 2019
@ioannisg ioannisg requested a review from agansari September 22, 2019 19:27
@ioannisg ioannisg force-pushed the arch_arm_userspace_make_z_arch_is_user_context_use_CMSIS branch from 5542cf4 to 5dd0bfd Compare September 22, 2019 20:28
@ioannisg ioannisg closed this Sep 23, 2019
@ioannisg ioannisg reopened this Sep 23, 2019
@ioannisg ioannisg force-pushed the arch_arm_userspace_make_z_arch_is_user_context_use_CMSIS branch 2 times, most recently from ade4eba to 7247f67 Compare September 23, 2019 21:12
@agansari agansari self-requested a review September 23, 2019 21:56
Refactor z_arch_is_user_context() for ARM, so it uses
the CMSIS CONTROL_nPRIV_Msk instead of hard-coded 0x1.
Fixing also some typos in include/arch/arm/syscall.h.

Signed-off-by: Ioannis Glaropoulos <[email protected]>
A commit that organizes the soc.h header of NXP SoCs:
- removing redundant inclusions of sys/util.h
- removing inclusions of device.h and kernel_includes.h
- including the auto-generated DTS board header
- including the fsl_common.h header
- fixing minor style issues

Signed-off-by: Ioannis Glaropoulos <[email protected]>
@ioannisg ioannisg force-pushed the arch_arm_userspace_make_z_arch_is_user_context_use_CMSIS branch from 7247f67 to da69067 Compare September 23, 2019 22:26
@andrewboie andrewboie merged commit 95c2968 into zephyrproject-rtos:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: ARM ARM (32-bit) Architecture Enhancement Changes/Updates/Additions to existing features Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants