samples/subsys/audio/sof: fix sys-ticks-per-sec to 15000 #46744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of CONFIG_SYS_CLOCK_TICKS_PER_SEC has side-effects that are not expected with tickless kernel mode. In bug zephyrproject-rtos#46378, application code is shown to run slower with higher sys clock tick value. In SOF bug zephyrproject-rtos#5921, audio quality issues were root-caused to k_timer inaccuracy with 50000 sys clock tick. Set the the value to 15000 for all SOF applications. All existing test cases pass with this value. BugLink: zephyrproject-rtos#46378 BugLink: thesofproject/sof#5921 Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
requested review from
ceolin,
lyakh,
lgirdwood,
mwasko and
marcinszkudlinski
andyross
approved these changes
Jun 21, 2022
|
|
||
| # Fix the sys ticks value until following bugs are solved: | ||
| # - https://github.com/zephyrproject-rtos/zephyr/issues/46378 | ||
| CONFIG_SYS_CLOCK_TICKS_PER_SEC=15000 |
There was a problem hiding this comment.
Not sure you really need the comment. 15 kHz seems like a very reasonable choice for timer precision in an audio application (just ~3 samples!). It's not clear to me why 50 kHz was chosen anyway, though personally I liked seeing the number as an exercise of the "tick rate is just an arbitrary precision" concept.
ceolin
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of CONFIG_SYS_CLOCK_TICKS_PER_SEC has side-effects that
are not expected with tickless kernel mode. In bug #46378, application
code is shown to run slower with higher sys clock tick value. In SOF
bug #5921, audio quality issues were root-caused to k_timer inaccuracy
with 50000 sys clock tick.
Set the the value to 15000 for all SOF applications. All existing
test cases pass with this value.
BugLink: #46378
BugLink: thesofproject/sof#5921
Signed-off-by: Kai Vehmanen [email protected]