Skip to content

samples/subsys/audio/sof: fix sys-ticks-per-sec to 15000 #46744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2022
Merged

samples/subsys/audio/sof: fix sys-ticks-per-sec to 15000 #46744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions samples/subsys/audio/sof/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,7 @@ CONFIG_COMPILER_OPT="-fstrict-overflow"
CONFIG_SCHED_DEADLINE=y
CONFIG_SCHED_CPU_MASK=y
CONFIG_SMP_BOOT_DELAY=y

# Fix the sys ticks value until following bugs are solved:
# - https://github.com/zephyrproject-rtos/zephyr/issues/46378
CONFIG_SYS_CLOCK_TICKS_PER_SEC=15000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you really need the comment. 15 kHz seems like a very reasonable choice for timer precision in an audio application (just ~3 samples!). It's not clear to me why 50 kHz was chosen anyway, though personally I liked seeing the number as an exercise of the "tick rate is just an arbitrary precision" concept.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyross I put the comment, because like you said, this should not really matter. Once we understand #46378 , we can make a more sensible decision where this should be set.