Skip to content

STM32: move dts.fixup files to soc level #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2018
Merged

STM32: move dts.fixup files to soc level #5859

merged 5 commits into from
Jan 28, 2018

Conversation

dwagenk
Copy link
Contributor

@dwagenk dwagenk commented Jan 28, 2018 •
edited
Loading

This was referenced Jan 28, 2018
Closed
Closed
galak
galak requested changes Jan 28, 2018
View reviewed changes
Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pull out the dts refactor’s into a separate PR. Those look good and happy to merge them right away.

galak
galak requested changes Jan 28, 2018
View reviewed changes
Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should be able to get SPI loopback w/o having board specific conf files.

@codecov-io
Copy link

codecov-io commented Jan 28, 2018 •
edited
Loading

Codecov Report

Merging #5859 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5859   +/-   ##
=======================================
  Coverage   54.33%   54.33%           
=======================================
  Files         457      457           
  Lines       43298    43298           
  Branches     8302     8302           
=======================================
  Hits        23524    23524           
  Misses      19635    19635           
  Partials      139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dfee62...00c029f. Read the comment docs.

Daniel Wagenknecht added 5 commits January 28, 2018 10:00
dts: stm32f0: move dts.fixup to soc family level
cbd743d 
This moves and merges the existing board-level dts.fixup files
for STM32 F0 SOC family into one soc family level dts.fixup file.
No new fixup blocks have been added, only fixup blocks, that were
part of at least one board level dts.fixup file are present in
soc family level dts.fixup file.

Contributes to #5707

Signed-off-by: Daniel Wagenknecht <[email protected]>
dts: stm32f4: move dts.fixup to soc family level
8a973cf 
This moves and merges the existing board-level dts.fixup files
for STM32 F4 SOC family into one soc family level dts.fixup file.
No new fixup blocks have been added, only fixup blocks, that were
part of at least one board level dts.fixup file are present in
soc family level dts.fixup file.

96b_carbon boards fixup block for Bluetooth HCI device via SPI
stays in board level dts.fixup file, because it is board specific.

Contributes to #5707

Signed-off-by: Daniel Wagenknecht <[email protected]>
dts: stm32f1: move dts.fixup to soc family level
fa4ef38 
This moves and merges the existing board-level dts.fixup files
for STM32 F1 SOC family into one soc family level dts.fixup file.
No new fixup blocks have been added, only fixup blocks, that were
part of at least one board level dts.fixup file are present in
soc family level dts.fixup file.

Contributes to #5707

Signed-off-by: Daniel Wagenknecht <[email protected]>
dts: stm32f3: move dts.fixup to soc family level
fa1b03d 
This moves and merges the existing board-level dts.fixup files
for STM32 F3 SOC family into one soc family level dts.fixup file.
No new fixup blocks have been added, only fixup blocks, that were
part of at least one board level dts.fixup file are present in
soc family level dts.fixup file.

Contributes to #5707

Signed-off-by: Daniel Wagenknecht <[email protected]>
dts: stm32l4: move dts.fixup to soc family level
00c029f 
This moves and merges the existing board-level dts.fixup files
for STM32 L4 SOC family into one soc family level dts.fixup file.
No new fixup blocks have been added, only fixup blocks, that were
part of at least one board level dts.fixup file are present in
soc family level dts.fixup file.

disco_l475_iot1 boards fixup blocks for devices connected via SPI
and I2C stay in board level dts.fixup file, because they are board
specific.

Contributes to #5707

Signed-off-by: Daniel Wagenknecht <[email protected]>
@dwagenk
Copy link
Contributor Author

dwagenk commented Jan 28, 2018

@ galak

Can you pull out the dts refactor’s into a separate PR. Those look good and happy to merge them right away.

changed this PR to only contain the dts refactor.

@dwagenk dwagenk changed the title STM32: move dts.fixup files to soc level and clean up spi_loopback test STM32: move dts.fixup files to soc level Jan 28, 2018
@galak galak merged commit 3f2b376 into zephyrproject-rtos:master Jan 28, 2018
@dwagenk dwagenk deleted the stm32_dts_and_spi branch January 28, 2018 18:00
@erwango
Copy link
Member

erwango commented Jan 29, 2018

@dwagenk , @ydamigos , @galak : This has been fast, thanks!

@erwango erwango mentioned this pull request Jan 29, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydamigos ydamigos ydamigos approved these changes

@galak galak galak approved these changes

@dbkinder dbkinder Awaiting requested review from dbkinder

@erwango erwango Awaiting requested review from erwango

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dwagenk @codecov-io @erwango @ydamigos @galak