-
Notifications
You must be signed in to change notification settings - Fork 7.3k
spi: stm32: convert remaining boards that support SPI to using dts #5836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As part of this issue, it would be good to populate .fixup files under dts rather than in boards. |
I've got a question regarding what to enable per default. Since dts.fixup is now moved to soc family level, there's not much work left for enabling SPI on these boards again.
in dts? Right now it doesn't matter, if I add it to .dts, as long as the if this is correct, then we can close this issue without any further action, because SPI on these boards work correctly, as long as |
@dwagenk It enables the generation of the following defines:
For now, we need to enable spiX both in boards dts file and in Kconfig file. Later, it should be done only in boards dts file. PR #5865 introduce a new approach and checks if |
OK, so for now I would add |
Yes, the ones that the board enables in Kconfig.defconfig. |
OK, thanks for the clarification! |
Configure SPI using DT for the following STM32 boards: 96b_neonkey nucleo_f091rc nucleo_f334r8 nucleo_f401re nucleo_l432kc nucleo_l476rg SPI nodes in <board>.dts file are populated matching boards existing pinmux default configuration and enabled in Kconfig.defconfig if SPI is enabled. For nucleo_l476rg board SPI2 and SPI3 nodes are not yet added, because of missing pinmux defines. Fixes #5836 Signed-off-by: Daniel Wagenknecht <[email protected]>
As a follow up to #5582 we need to convert the stm32 boards, that already support SPI to using dts for SPI configuration.
Right now building e.g. tests\drivers\spi\spi_loopback for nucleo_f091rc fails, because spi_ll_stm32.c driver relies on SPI_BASE_ADDRESS, SPINAME, SPIIRQ and SPI_IRQ_PRI wich are not defined yet for this board.
I guess this affects the following boards (i generated this list by searching which boards are stm32 based and have a default pinmux for SPI in their pinmux.c):
The text was updated successfully, but these errors were encountered: