-
Notifications
You must be signed in to change notification settings - Fork 7.3k
ext: mcux: Add import script and import latest version #6633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the import script, would be good maybe in the commit message to show an example invocation of the script.
Codecov Report
@@ Coverage Diff @@
## master #6633 +/- ##
=======================================
Coverage 55.26% 55.26%
=======================================
Files 467 467
Lines 51641 51641
Branches 9886 9886
=======================================
Hits 28541 28541
Misses 19190 19190
Partials 3910 3910 Continue to review full report at Codecov.
|
|
||
zephyr_include_directories(.) | ||
|
||
zephyr_sources_ifdef(CONFIG_GPIO_MCUX_IGPIO fsl_gpio.c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will drivers/imx be able to handle both imx-rt and imx6/7/8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the idea, but I found an exception today. This works for rt, imx6, imx7d, and imx8; but not imx7ulp.
Thank you @MaureenHelm ! When I'm back in the office tomorrow, I'll rebase my LTE modem branch and test this update |
@MaureenHelm: are you also setting up a PR for drivers/serial/uart_mcux.c to set enableRxRTS / enableTxCTS based on Kconfig options? |
Hi @MaureenHelm, there are couple of nxp hal fixes in gPTP PR #6570.
How could we get those fixes merged in upstream nxp hal? |
Thanks @jukkar, I'll file an internal ticket. Only the first and third commits need to go upstream, the second modifies a file unique to Zephyr. |
@MaureenHelm I tested this PR along with my current modem driver and everything seemed to work just fine. As a part of that testing, I rebased a patch to add the Kconfig settings for HW Flow Control support here: mike-scott@a296fcc Let me know if you want me to put that up as a PR linked to this one. Or feel free to add it here if you want. |
@MaureenHelm any thoughts on my comments? I asked, because I can see us wanting to merge the re-org change and related commits while we wait on any discussion about the updated import. (Not sure how the re-org will impact PR #6367 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general all looks good, but maybe the import script should not be in the root of scripts/
, but rather keep it somewhere in scripts/support
?
IMO this should be in ext/hal/nxp/mcux/scripts, all in one place and when we move HALs out of the tree at some point, the script will be part of the deal. |
|
Is this still stuck in license review hell? |
Yes. The governing board is still discussing it. |
NXP periodically releases new versions of the MCUXpresso SDK (mcux). Automate the process of importing mcux into zephyr with a python script. Example usage: $ import_mcux_sdk.py -f SDK_2.3.0_EVK-MIMXRT1050.tar.gz Signed-off-by: Maureen Helm <[email protected]>
Updates the imported device header files and drivers for k64 and lpc54114 using the new mcux import script. Drivers are relicensed to BSD-3-Clause-Clear in this newer version of MCUXpresso SDK. Origin: NXP MCUXpresso SDK 2.3.0 URL: mcux.nxp.com Maintained-by: External Signed-off-by: Maureen Helm <[email protected]>
Updates the device header files and drivers for imxrt1051 and imxrt1052 using the new mcux import script. Device header files and drivers are relicensed to BSD-3-Clause-Clear in this newer version of MCUXpresso SDK. Origin: NXP MCUXpresso SDK 2.3.0 URL: mcux.nxp.com Maintained-by: External Signed-off-by: Maureen Helm <[email protected]>
Rebased to latest master |
Do we want to pull the script out into its own PR, and close this for now? |
Sure |
Adds a new python script to automate importing the MCUXpresso SDK into Zephyr and uses the script to import the latest version. Parts of the SDK are re-licensed with a BSD-3-Clause-Clear license, which is a new license to Zephyr.
Updates README to follow template and reflect new licensing.
Fixes #5833
@mike-scott @vakulgarg The new uart driver supports hw flow control