Skip to content

ext: mcux: Add import script and import latest version #6633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

ext: mcux: Add import script and import latest version #6633

wants to merge 3 commits into from

Conversation

MaureenHelm
Copy link
Member

Adds a new python script to automate importing the MCUXpresso SDK into Zephyr and uses the script to import the latest version. Parts of the SDK are re-licensed with a BSD-3-Clause-Clear license, which is a new license to Zephyr.

Updates README to follow template and reflect new licensing.

Fixes #5833

@mike-scott @vakulgarg The new uart driver supports hw flow control

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the import script, would be good maybe in the commit message to show an example invocation of the script.

@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #6633 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6633   +/-   ##
=======================================
  Coverage   55.26%   55.26%           
=======================================
  Files         467      467           
  Lines       51641    51641           
  Branches     9886     9886           
=======================================
  Hits        28541    28541           
  Misses      19190    19190           
  Partials     3910     3910

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def4a4c...90a9cbc. Read the comment docs.


zephyr_include_directories(.)

zephyr_sources_ifdef(CONFIG_GPIO_MCUX_IGPIO fsl_gpio.c)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will drivers/imx be able to handle both imx-rt and imx6/7/8?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the idea, but I found an exception today. This works for rt, imx6, imx7d, and imx8; but not imx7ulp.

@mike-scott
Copy link
Contributor

Thank you @MaureenHelm ! When I'm back in the office tomorrow, I'll rebase my LTE modem branch and test this update

@mike-scott
Copy link
Contributor

@MaureenHelm: are you also setting up a PR for drivers/serial/uart_mcux.c to set enableRxRTS / enableTxCTS based on Kconfig options?

@jukkar
Copy link
Member

jukkar commented Mar 16, 2018

Hi @MaureenHelm, there are couple of nxp hal fixes in gPTP PR #6570.
The patches are called:

  • ext: hal: nxp: mcux: Fix ethernet timestamping driver
  • ext: hal: nxp: mcux: Enable enhanced buffer desc mode if needed
  • ext: hal: nxp: mcux: Fix PTP event packet type check

How could we get those fixes merged in upstream nxp hal?

@MaureenHelm
Copy link
Member Author

Hi @MaureenHelm, there are couple of nxp hal fixes in gPTP PR #6570.
The patches are called:

ext: hal: nxp: mcux: Fix ethernet timestamping driver
ext: hal: nxp: mcux: Enable enhanced buffer desc mode if needed
ext: hal: nxp: mcux: Fix PTP event packet type check
How could we get those fixes merged in upstream nxp hal?

Thanks @jukkar, I'll file an internal ticket. Only the first and third commits need to go upstream, the second modifies a file unique to Zephyr.

@mike-scott
Copy link
Contributor

@MaureenHelm I tested this PR along with my current modem driver and everything seemed to work just fine. As a part of that testing, I rebased a patch to add the Kconfig settings for HW Flow Control support here: mike-scott@a296fcc Let me know if you want me to put that up as a PR linked to this one. Or feel free to add it here if you want.

@galak
Copy link
Collaborator

galak commented Mar 16, 2018

@MaureenHelm any thoughts on my comments? I asked, because I can see us wanting to merge the re-org change and related commits while we wait on any discussion about the updated import. (Not sure how the re-org will impact PR #6367

Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general all looks good, but maybe the import script should not be in the root of scripts/, but rather keep it somewhere in scripts/support?

@nashif
Copy link
Member

nashif commented Mar 22, 2018

In general all looks good, but maybe the import script should not be in the root of scripts/, but rather keep it somewhere in scripts/support?

IMO this should be in ext/hal/nxp/mcux/scripts, all in one place and when we move HALs out of the tree at some point, the script will be part of the deal.

@MaureenHelm
Copy link
Member Author

  • Rebased to latest master
  • Moved script to ext/hal/nxp/mcux/scripts
  • Added example usage to commit message

@pfalcon pfalcon requested a review from dleach02 April 3, 2018 16:29
@galak galak added the EXT Has change or related to ext/ (obsolete) label Apr 12, 2018
@mike-scott
Copy link
Contributor

Is this still stuck in license review hell?

@MaureenHelm
Copy link
Member Author

Is this still stuck in license review hell?

Yes. The governing board is still discussing it.

NXP periodically releases new versions of the MCUXpresso SDK (mcux).
Automate the process of importing mcux into zephyr with a python script.

Example usage:

$ import_mcux_sdk.py -f SDK_2.3.0_EVK-MIMXRT1050.tar.gz

Signed-off-by: Maureen Helm <[email protected]>
Updates the imported device header files and drivers for k64 and
lpc54114 using the new mcux import script. Drivers are relicensed to
BSD-3-Clause-Clear in this newer version of MCUXpresso SDK.

Origin: NXP MCUXpresso SDK 2.3.0
URL: mcux.nxp.com
Maintained-by: External

Signed-off-by: Maureen Helm <[email protected]>
Updates the device header files and drivers for imxrt1051 and imxrt1052
using the new mcux import script. Device header files and drivers are
relicensed to BSD-3-Clause-Clear in this newer version of MCUXpresso
SDK.

Origin: NXP MCUXpresso SDK 2.3.0
URL: mcux.nxp.com
Maintained-by: External

Signed-off-by: Maureen Helm <[email protected]>
@MaureenHelm
Copy link
Member Author

Rebased to latest master

@galak
Copy link
Collaborator

galak commented Jul 13, 2018

Do we want to pull the script out into its own PR, and close this for now?

@MaureenHelm
Copy link
Member Author

Do we want to pull the script out into its own PR, and close this for now?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EXT Has change or related to ext/ (obsolete) platform: NXP NXP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants