Improve video sw generator #69817
Merged
Improve video sw generator #69817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIDEO_PATTERN_FPS should be coherently used across the entire code file. Signed-off-by: Phi Bang Nguyen <[email protected]>
Add XRGB32 pixel format Signed-off-by: Phi Bang Nguyen <[email protected]>
Add support for XRGB32 pixel format as this is useful to test camera and display drivers on i.MX RT11xx Signed-off-by: Phi Bang Nguyen <[email protected]>
|
Hi @loicpoulain , |
Add code to handle invalid formats when setting format Signed-off-by: Phi Bang Nguyen <[email protected]>
|
@loicpoulain I made a mistake in the commit "drivers: video: sw_generator: Fix set_format Instead of moving |
loicpoulain
approved these changes
Mar 14, 2024
|
Added @loicpoulain as the assignee as he is the maintainer of the drivers\video @danieldegrasse can you give this a review? |
dleach02
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for XRGB32 format to the video sw generator as this is useful to test camera and display pipeline on i.MX RT11XX. It also contains some minor fixes.
The first commit (which adds XRGB fourcc) is part of another PR and could be dropped if that PR is merged first :