Configure lpuart flow control pin mux

[MarkWangChinese]

No description provided.

[bas-archembedded]

@MarkWangChinese Doesn't this just check if the FLOWCONTROL state exists and never actually select it ?

[MarkWangChinese]

@MarkWangChinese Doesn't this just check if the FLOWCONTROL state exists and never actually select it ?

Sorry, I don't get your point, do you mean how to enable the uart flowcontrol? It is enabled by the DT that can be overwritten by overlay file.

[bas-archembedded]

@MarkWangChinese Doesn't this just check if the FLOWCONTROL state exists and never actually select it ?

Sorry, I don't get your point, do you mean how to enable the uart flowcontrol? It is enabled by the DT that can be overwritten by overlay file.

From what I read, err = pinctrl_lookup_state(config->pincfg, PINCTRL_STATE_FLOWCONTROL, &state); only looks up the state but it never actually transitions into that state anywhere ? IMHO this needs to be pinctrl_apply_state(config->pincfg, PINCTRL_STATE_FLOWCONTROL); ? pinctrl_apply_state() checks if the state is valid and if not returns error and in that case it will use "default" pinmux as the lpuart driver code then applies the default state.

[MarkWangChinese]

@MarkWangChinese Doesn't this just check if the FLOWCONTROL state exists and never actually select it ?

Sorry, I don't get your point, do you mean how to enable the uart flowcontrol? It is enabled by the DT that can be overwritten by overlay file.

From what I read, err = pinctrl_lookup_state(config->pincfg, PINCTRL_STATE_FLOWCONTROL, &state); only looks up the state but it never actually transitions into that state anywhere ? IMHO this needs to be pinctrl_apply_state(config->pincfg, PINCTRL_STATE_FLOWCONTROL); ? pinctrl_apply_state() checks if the state is valid and if not returns error and in that case it will use "default" pinmux as the lpuart driver code then applies the default state.

Yes, I think you are right, Thanks. The pinctrl_lookup_state should be replaced by pinctrl_apply_state through the static codes review. I remember that I did test with bluetooth audio sample. Will you create pr to fix it?

[bas-archembedded]

@MarkWangChinese Doesn't this just check if the FLOWCONTROL state exists and never actually select it ?

Sorry, I don't get your point, do you mean how to enable the uart flowcontrol? It is enabled by the DT that can be overwritten by overlay file.

From what I read, err = pinctrl_lookup_state(config->pincfg, PINCTRL_STATE_FLOWCONTROL, &state); only looks up the state but it never actually transitions into that state anywhere ? IMHO this needs to be pinctrl_apply_state(config->pincfg, PINCTRL_STATE_FLOWCONTROL); ? pinctrl_apply_state() checks if the state is valid and if not returns error and in that case it will use "default" pinmux as the lpuart driver code then applies the default state.

Yes, I think you are right, Thanks. The pinctrl_lookup_state should be replaced by pinctrl_apply_state through the static codes review. I remember that I did test with bluetooth audio sample. Will you create pr to fix it?

I have created it here: #88866. Thanks for checking :)