drivers: serial: uart_mcux_lpuart: Fix pinctrl flow control #88866
+35
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: NXP Drivers
github-actions
bot
requested review from
dbaluta,
dcpleung,
decsny,
dleach02,
manuargue,
mmahadevan108 and
Raymond0225
bas-archembedded
force-pushed
the
dev/fix_flowctrl_pinctrl
branch
from
63d58b9 to
f350689
Compare
|
@bas-archembedded is there a test case in Zephyr that would test for this? |
dleach02
previously approved these changes
Apr 23, 2025
|
@dleach02 Not that I can find, but I have tested this using the "hci_nxp_setup" stuff to bring up a NXP IW612 based module and getting bluetooth and WIFI working at the same time with independent firmware(s). I am still waiting to get access to some proprietary protocol information of that module but it seems it needs a nudge over the RTS line to get going after the WIFI firmware was loaded. |
|
@bas-archembedded can you address the compliance error. |
Currently the driver code does not actually request the flow control state, it only checks if the state exists. To fix this we should simply call pinctrl_apply_state() and if that fails, meaning no flow control state exists, fall back to default pin mux settings. Another case that needed fixing is run time flow control enabling ie in the case where we have a WIFI/bluetooth module connected and we initially operate without flow control but later enable it after firmware download. This patch addresses this as well by making a generic function to achieve this. Signed-off-by: Bas van Loon <[email protected]>
bas-archembedded
force-pushed
the
dev/fix_flowctrl_pinctrl
branch
from
f350689 to
109a90e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the driver code does not actually request the flow control state, it only checks if the state exists. To fix this we should simply call pinctrl_apply_state() and if that fails, meaning no flow control state exists, fall back to default pin mux settings.
Another case that needed fixing is run time flow control enabling ie in the case where we have a WIFI/bluetooth module connected and we initially operate without flow control but later enable it after firmware download.
This patch addresses this as well by making a generic function to achieve this.