Some misc fixes on CSI driver #71860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: NXP Drivers
zephyrbot
requested review from
bperseghetti,
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
EmilioCBen,
loicpoulain,
manuargue,
PetervdPerk-NXP and
yvanderv
decsny
previously approved these changes
Apr 24, 2024
|
@ngphibang please address the CI problem |
|
@dleach02 The CI problem is not due to my changes. In fact, it is because the "Install Packages" step failed. |
loicpoulain
reviewed
May 6, 2024
The HAS_MCUX_CSI (as well as all the HAS_MCUX_XXX) config was obsolete and has been replaced by the DT_HAS_NXP_IMX_CSI_ENABLED (i.e. DT_HAS_XXX_ENABLED). Drop it as well as all the dependencies on it. Signed-off-by: Phi Bang Nguyen <[email protected]>
Run clang format before making any changes Signed-off-by: Phi Bang Nguyen <[email protected]>
The CSI should always propagate the get_fmt request down to the sensor. It should not return a format by it own unless it contains a test pattern generator inside it. The problem with the legacy code is that this code snippet is never reached if the sensor could return a format. In case the sensor failed to return a format, these codes are reached but the returned format makes no sense and its value was not initialized. Signed-off-by: Phi Bang Nguyen <[email protected]>
The pixel format config is not used in the low level driver. Drop it. Signed-off-by: Phi Bang Nguyen <[email protected]>
|
@danieldegrasse @loicpoulain : Thanks for the comments. Is it ok for you now ? |
danieldegrasse
approved these changes
May 6, 2024
decsny
approved these changes
May 6, 2024
dleach02
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some misc fixes for CSI driver. It is splitted from #69810 to ease the review process as required by @loicpoulain.
It already got reviewed by Daniel Degrasse.