drivers: spi: esp32: Fix clock initialization #73807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: SPI
zephyrbot
requested review from
marekmatej,
nordic-krch,
tbursztyka,
teburd and
uLipe
LucasTambor
force-pushed
the
bugfix/spi_clk
branch
from
4d2ec39 to
1bbab6f
Compare
sylvioalves
previously approved these changes
Jun 6, 2024
marekmatej
requested changes
Jun 6, 2024
LucasTambor
force-pushed
the
bugfix/spi_clk
branch
from
1bbab6f to
fa1eac6
Compare
marekmatej
previously approved these changes
Jun 6, 2024
LucasTambor
force-pushed
the
bugfix/spi_clk
branch
3 times, most recently
from
95e1a1a to
de44848
Compare
The clock should be initialised only once at the drivers init function. Check wether the subsys needs to be disabled in peripheral initialization according to reset reason in clock control. Signed-off-by: Lucas Tamborrino <[email protected]>
LucasTambor
force-pushed
the
bugfix/spi_clk
branch
from
de44848 to
0a791d3
Compare
Move esp32 based boards to `soc` folder to avoid repeated files. Signed-off-by: Lucas Tamborrino <[email protected]>
LucasTambor
force-pushed
the
bugfix/spi_clk
branch
from
0a791d3 to
00a4ebe
Compare
marekmatej
approved these changes
Jun 10, 2024
sylvioalves
approved these changes
Jun 10, 2024
sylvioalves
added a commit
to sylvioalves/zephyr
that referenced
this pull request
Jun 21, 2024
Both MDIO and Ethernet drivers share the same clock subsystem. After clock control update in zephyrproject-rtos#73807, clock_control_on() now returns -EALREADY for already initialized clock subsystem. As a result, ethernet driver won't initialize as needed. Fixes zephyrproject-rtos#74440 Signed-off-by: Sylvio Alves <[email protected]>
nashif
pushed a commit
that referenced
this pull request
Jun 24, 2024
Both MDIO and Ethernet drivers share the same clock subsystem. After clock control update in #73807, clock_control_on() now returns -EALREADY for already initialized clock subsystem. As a result, ethernet driver won't initialize as needed. Fixes #74440 Signed-off-by: Sylvio Alves <[email protected]>
Chenhongren
pushed a commit
to Chenhongren/zephyr
that referenced
this pull request
Aug 26, 2024
Both MDIO and Ethernet drivers share the same clock subsystem. After clock control update in zephyrproject-rtos#73807, clock_control_on() now returns -EALREADY for already initialized clock subsystem. As a result, ethernet driver won't initialize as needed. Fixes zephyrproject-rtos#74440 (cherry picked from commit cc29fc1) Original-Signed-off-by: Sylvio Alves <[email protected]> GitOrigin-RevId: cc29fc1 Change-Id: Idcf0bb8c046f308369dcac452a5b206a79dc18e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5653396 Reviewed-by: Ting Shen <[email protected]> Tested-by: Ting Shen <[email protected]> Tested-by: ChromeOS Prod (Robot) <[email protected]> Commit-Queue: Ting Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clock should be initialised only once at the
drivers init function.
Check wether the subsys needs to be disabled in
peripheral initialization according to reset reason in clock control.