bugfix: driver: esp32: eth_mdio: fix clock and function calls #74442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
from
48e8f89 to
b6e045f
Compare
zephyrbot
requested review from
decsny,
lmajewski,
LucasTambor,
marekmatej,
pdgendt and
uLipe
LucasTambor
previously approved these changes
Jun 17, 2024
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
2 times, most recently
from
a5bcf24 to
8619fe3
Compare
|
It is also important to mention that current |
sylvioalves
changed the title
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
from
26573fb to
b7fff40
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
from
b7fff40 to
722b380
Compare
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
3 times, most recently
from
394669c to
79169f6
Compare
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
from
79169f6 to
668ba35
Compare
Both MDIO and Ethernet drivers share the same clock subsystem. After clock control update in zephyrproject-rtos#73807, clock_control_on() now returns -EALREADY for already initialized clock subsystem. As a result, ethernet driver won't initialize as needed. Fixes zephyrproject-rtos#74440 Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
from
668ba35 to
cbdfe89
Compare
|
Bebased again to check whether Babblesim stops failing. |
bbilas
reviewed
Jun 21, 2024
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
2 times, most recently
from
e997047 to
dc3a6bf
Compare
bbilas
reviewed
Jun 21, 2024
When external PHY has crystal, ESP32 can be configured to use custom GPIO as clock source for it. However, due to latest clock subsystem and hal updates, current driver fails to build and blocks its usage. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
bugfix/eth_mdio_clock_issue
branch
from
dc3a6bf to
a63d426
Compare
bbilas
approved these changes
Jun 21, 2024
marekmatej
approved these changes
Jun 21, 2024
iwasz
added a commit
to iwasz/zephyr
that referenced
this pull request
Jul 25, 2024
When GPIO17 or 16 is used as an external REF_CLK signal, the output is enabled in eth_esp32.c This was added in PR number zephyrproject-rtos#65759 and then refined in PR zephyrproject-rtos#74442. However this does not work for PHYs which need the REF_CLK for MDIO communication, such as LAN8720A. In such cases phy_mii driver tries to get the ID of such a PHY before REF_CLK is present. Therefore in this PR I propose to move REF_CLK initialization from eth_esp32.c to mdio_esp32.c which gets initialized before PHY and ETH. Signed-off-by: Łukasz Iwaszkiewicz <[email protected]>
kartben
pushed a commit
that referenced
this pull request
Apr 23, 2025
When GPIO17 or 16 is used as an external REF_CLK signal, the output is enabled in eth_esp32.c This was added in PR number #65759 and then refined in PR #74442. However this does not work for PHYs which need the REF_CLK for MDIO communication, such as LAN8720A. In such cases phy_mii driver tries to get the ID of such a PHY before REF_CLK is present. Therefore in this PR I propose to move REF_CLK initialization from eth_esp32.c to mdio_esp32.c which gets initialized before PHY and ETH. Signed-off-by: Łukasz Iwaszkiewicz <[email protected]>
owuatmosic
pushed a commit
to owuatmosic/zephyr
that referenced
this pull request
Apr 24, 2025
When GPIO17 or 16 is used as an external REF_CLK signal, the output is enabled in eth_esp32.c This was added in PR number zephyrproject-rtos#65759 and then refined in PR zephyrproject-rtos#74442. However this does not work for PHYs which need the REF_CLK for MDIO communication, such as LAN8720A. In such cases phy_mii driver tries to get the ID of such a PHY before REF_CLK is present. Therefore in this PR I propose to move REF_CLK initialization from eth_esp32.c to mdio_esp32.c which gets initialized before PHY and ETH. Signed-off-by: Łukasz Iwaszkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both MDIO and Ethernet drivers share the same clock subsystem. After clock control update in #73807, clock_control_on() now returns -EALREADY for already initialized clock subsystem. As a result, ethernet driver won't initialize as needed.
Due to the same clock control and hal updates, internal functions required updates.
Fixes #74440
Fixes #74632
As this PR updates hal_espressif, it also fixes #74632.