Change libmetal to build non-recursively. #7762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkinder
reviewed
May 22, 2018
Codecov Report
@@ Coverage Diff @@
## master #7762 +/- ##
=======================================
Coverage 55.01% 55.01%
=======================================
Files 483 483
Lines 53949 53949
Branches 10494 10494
=======================================
Hits 29680 29680
Misses 19983 19983
Partials 4286 4286Continue to review full report at Codecov.
|
libmetal itself isn't an ipc library, its a generic HAL abstraction library so move it into ext/hal where it belongs. Signed-off-by: Kumar Gala <[email protected]>
Pull in a slightly more recent version of libmetal with changes to the build system to improve integration with Zephyr. This change will break anything that builds with Zephyr and libmetal (which at this point is only the open-amp example). Will fix that shortly. Signed-off-by: Kumar Gala <[email protected]>
With recent changes to libmetal we can now include and build it directly as a zephyr library rather than doing a recursive make. We remove ext/hal/libmetal.cmake as part of this change and introduce a Kconfig option for libmetal. This is a partial fix for issue zephyrproject-rtos#7673. Signed-off-by: Kumar Gala <[email protected]>
|
Closing this since its all part of PR #7769 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #7673.