Skip to content

Eliminate recursive make in OpenAMP integration #7673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaureenHelm opened this issue May 19, 2018 · 0 comments
Closed

Eliminate recursive make in OpenAMP integration #7673

MaureenHelm opened this issue May 19, 2018 · 0 comments
Assignees
@galak
Labels
area: IPC Inter-Process Communication bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Milestone
v1.12.0

Comments

@MaureenHelm
Copy link
Member

From @SebastianBoe in #7416:

Recursive-make must be avoided when possible.
For OpenThread it was not possible due to the sheer size of the OpenThread build system.
For libmetal it is possible to avoid recursive-make because the project is small and easy to build.
@MaureenHelm MaureenHelm added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug area: IPC Inter-Process Communication labels May 19, 2018
@carlescufi carlescufi added this to the v1.12.0 milestone May 22, 2018
@galak galak mentioned this issue May 22, 2018
Closed
galak added a commit to galak/zephyr that referenced this issue May 22, 2018
@galak
ext: libmetal: Change build integration so its not recursive
cc4c1fc 
With recent changes to libmetal we can now include and build it directly
as a zephyr library rather than doing a recursive make.  We remove
ext/hal/libmetal.cmake as part of this change and introduce a Kconfig
option for libmetal.

This is a partial fix for issue zephyrproject-rtos#7673.

Signed-off-by: Kumar Gala <[email protected]>
@galak galak mentioned this issue May 22, 2018
Merged
galak added a commit to galak/zephyr that referenced this issue May 23, 2018
@galak
ext: libmetal: Change build integration so its not recursive
7341043 
With recent changes to libmetal we can now include and build it directly
as a zephyr library rather than doing a recursive make.  We remove
ext/hal/libmetal.cmake as part of this change and introduce a Kconfig
option for libmetal.

This is a partial fix for issue zephyrproject-rtos#7673.

Signed-off-by: Kumar Gala <[email protected]>
galak added a commit to galak/zephyr that referenced this issue May 23, 2018
@galak
ext: open-amp: Change build integration so its not recursive
dce3622 
With recent changes to open-amp we can now include and build it directly
as a zephyr library rather than doing a recursive make.  We remove
ext/lib/ipc/open-amp.cmake as part of this change and introduce a
Kconfig option for open-amp.

Fixes: zephyrproject-rtos#7673

Signed-off-by: Kumar Gala <[email protected]>
galak added a commit to galak/zephyr that referenced this issue May 23, 2018
@galak
ext: libmetal: Change build integration so its not recursive
15e8aeb 
With recent changes to libmetal we can now include and build it directly
as a zephyr library rather than doing a recursive make.  We remove
ext/hal/libmetal.cmake as part of this change and introduce a Kconfig
option for libmetal.

This is a partial fix for issue zephyrproject-rtos#7673.

Signed-off-by: Kumar Gala <[email protected]>
galak added a commit to galak/zephyr that referenced this issue May 23, 2018
@galak
ext: open-amp: Change build integration so its not recursive
b2a7971 
With recent changes to open-amp we can now include and build it directly
as a zephyr library rather than doing a recursive make.  We remove
ext/lib/ipc/open-amp.cmake as part of this change and introduce a
Kconfig option for open-amp.

Fixes: zephyrproject-rtos#7673

Signed-off-by: Kumar Gala <[email protected]>
galak added a commit that referenced this issue May 24, 2018
@galak
ext: libmetal: Change build integration so its not recursive
f6fb8b8 
With recent changes to libmetal we can now include and build it directly
as a zephyr library rather than doing a recursive make.  We remove
ext/hal/libmetal.cmake as part of this change and introduce a Kconfig
option for libmetal.

This is a partial fix for issue #7673.

Signed-off-by: Kumar Gala <[email protected]>
@galak galak closed this as completed in 4e8438b May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galak galak

Labels
area: IPC Inter-Process Communication bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
v1.12.0
Development

No branches or pull requests
3 participants
@MaureenHelm @carlescufi @galak