Enhancements for spi_dw driver #87716
Merged
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rename the PR, it's improving driver support but not implementing enhanced SPI operation. I think you could drop the first commit about rx-delay, see #87427 (if you have input on such improvements, please do) |
cujomalainey
changed the title
yep that indeed appear to be the same api, i will drop that patch and review it later for compatibility, but a surface level check appears to be exactly what we need. |
The DFS(Data Frame Size) is at CTRLR0[4:0] in HSSI controller. Signed-off-by: Younghyun Park <[email protected]>
The TXFTLR register has 2 major fields which are TFT for triggering interrupt threshold and TXFTLR for starting transfer threshold. This is to ensure that sufficient data is ready for starting transfer. Signed-off-by: Younghyun Park <[email protected]>
Read the Synopsys SSI component version to extend supported capability based on the version. Signed-off-by: Younghyun Park <[email protected]>
|
@tbursztyka mind if i get a re-review? |
tbursztyka
approved these changes
Apr 9, 2025
teburd
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-attempt of #77492 minus the API modification patches that will be modified and sent in a formal change later outside of the driver specific changes.