Bluetooth: host: Ensure BASS notifications are sent #88243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
reviewed
Apr 7, 2025
jthm-ot
force-pushed
the
work_bap_scan_delegator
branch
2 times, most recently
from
0a31330 to
f62b10f
Compare
Thalley
requested changes
Apr 10, 2025
jthm-ot
force-pushed
the
work_bap_scan_delegator
branch
2 times, most recently
from
cccd501 to
2743aac
Compare
Thalley
requested changes
Apr 10, 2025
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
subsys/bluetooth/audio/bap_scan_delegator.c:113
- The 'updated' flag in 'struct bass_recv_state_flags' is modified in set_receive_state_changed_cb without holding a lock, while reads/modifications elsewhere are protected by a mutex. Consider using an atomic type or ensuring all accesses are guarded by a mutex to prevent potential data races.
flags->updated = true;
subsys/bluetooth/audio/bap_scan_delegator.c:585
- [nitpick] The function name 'scan_delegator_add_src' is less descriptive compared to its original name. Consider reverting to or adopting a more self-explanatory name, such as 'scan_delegator_add_source', for clarity.
static int scan_delegator_add_src(struct bt_conn *conn,
2743aac to
c837ed5
Compare
jthm-ot
force-pushed
the
work_bap_scan_delegator
branch
4 times, most recently
from
3c4a0ec to
9b0620d
Compare
Thalley
approved these changes
Apr 21, 2025
Update bit array (number of connections) added for each receive state. Notifications are attempted to be sent in the system workqueue and retried if failing. Issue zephyrproject-rtos#85487 Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot
force-pushed
the
work_bap_scan_delegator
branch
from
9b0620d to
f08f5f1
Compare
github-actions
bot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
jhedberg,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
fredrikdanebjer
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bit array (number of connections) added for each receive state. Notifications are attempted to be sent in the system workqueue and retried if failing.
Fixes #85487