Skip to content

Bluetooth: Audio: Ensure BASS notifications are sent #85487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Thalley opened this issue Feb 10, 2025 · 0 comments · Fixed by #88243
Closed

Bluetooth: Audio: Ensure BASS notifications are sent #85487

Thalley opened this issue Feb 10, 2025 · 0 comments · Fixed by #88243
Assignees
Labels
area: Bluetooth Audio area: Bluetooth Enhancement Changes/Updates/Additions to existing features

Comments

@Thalley
Copy link
Collaborator

Thalley commented Feb 10, 2025

Is your enhancement proposal related to a problem? Please describe.
In the BASS / Scan Delegator implementation we are sending notifications in the same thread that is handling the request (either local or remote request). If we are connected to multiple BASS clients, this will require several ATT buffers in order to enqueue. If we run out of buffers, then the notifications won't be sent, which is a spec violation.

However this will rarely happen, and can be worked around by increasing CONFIG_BT_ATT_TX_COUNT and thus more of an enhancement than a bug.

Describe the solution you'd like
Several other services in LE Audio (AICS, VCS, VOCS, HAS, etc.) have implemented a simple solution that sets a bit for each client that shall receive the notification, and then those are attempted to be sent in the system workqueue and retried if failing. This will ensure that the notifications are not just dropped if we are out of buffers.

Describe alternatives you've considered
N/A

Additional context
N/A

@Thalley Thalley added Enhancement Changes/Updates/Additions to existing features area: Bluetooth area: Bluetooth Audio labels Feb 10, 2025
@Thalley Thalley self-assigned this Feb 10, 2025
@Thalley Thalley assigned jrth and jthm-ot and unassigned jrth and Thalley Mar 25, 2025
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 7, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 8, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 9, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 10, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 10, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 11, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 11, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 11, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 13, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 14, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
jthm-ot added a commit to jthm-ot/zephyr that referenced this issue Apr 23, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue zephyrproject-rtos#85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
kartben pushed a commit that referenced this issue Apr 25, 2025
Update bit array (number of connections) added for each receive state.
Notifications are attempted to be sent in the system workqueue and
retried if failing.

Issue #85487

Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
@github-project-automation github-project-automation bot moved this from To do to Done in Bluetooth LE Audio Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Audio area: Bluetooth Enhancement Changes/Updates/Additions to existing features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants